Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable v1 blobstore dynamo collector in v2 #1213

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Disable v1 blobstore dynamo collector in v2 #1213

merged 1 commit into from
Feb 5, 2025

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Feb 5, 2025 •
edited
Loading

Disable v1 blobstore dynamo collector in v2

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork requested review from dmanc and ian-shim February 5, 2025 00:22
ian-shim
ian-shim approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're going to share the same Metrics in both v1 and v2.
Maybe not in this PR, but can we have the collector implementation for v2 as well? We would need to export the blob count in QUEUED status for example

@pschork pschork merged commit 1c6a730 into master Feb 5, 2025
10 checks passed
@pschork pschork deleted the pschork/disable_blobstore_collector branch February 5, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pschork @dmanc @ian-shim