Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove on chain cert verification from relay payload retriever #1205

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Remove on chain cert verification from relay payload retriever #1205

merged 5 commits into from
Feb 5, 2025

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Feb 3, 2025 •
edited
Loading

Why are these changes needed?

  • Since we will have multiple implementations of PayloadRetriever, it doesn't make sense to verify the DA cert inside any given retriever: verification only needs to happen once, before any retrieval is attempted
  • This PR removes cert verification from the RelayPayloadRetriever

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@litt3
Remove on chain cert verification from relay payload retreiver
ac4398d 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3 litt3 self-assigned this Feb 3, 2025
@litt3
Check and set defaults before using config struct
7bcc50a 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3 litt3 marked this pull request as ready for review February 3, 2025 21:02
@litt3
Merge branch 'master' into remove-cert-verify-on-fetch
b7a8014 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
samlaf
samlaf approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

@litt3 litt3 merged commit d0f49e9 into Layr-Labs:master Feb 5, 2025
8 checks passed
@litt3 litt3 deleted the remove-cert-verify-on-fetch branch February 5, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@cody-littley cody-littley cody-littley approved these changes

@ethenotethan ethenotethan Awaiting requested review from ethenotethan

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litt3 @samlaf @cody-littley