Functional tests #1167
Merged
Functional tests #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Add quorum support and add extra tests
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Skip tests in CI
dmanc
approved these changes
Jan 27, 2025
| @@ -64,6 +64,20 @@ func DefaultLoggerConfig() LoggerConfig { | |||
| } | |||
| } | |||
|
|
|||
| // DefaultTextLoggerConfig returns a LoggerConfig with the default settings for a text logger. | |||
| // For use in tests or other scenarios where the logs are consumed by humans. | |||
| func DefaultTextLoggerConfig() LoggerConfig { | |||
There was a problem hiding this comment.
Could we add maybe `DefaultConsoleLoggerConfig". Only difference is NoColor = false. Then in cases where we run stuff locally we can use that, otherwise CI defaults to TextLogger?
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
tests that run against preprod