Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 contract testing #1032

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

V2 contract testing #1032

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3a6ccf3
restructure testing
0x0aa0 Dec 19, 2024
2a2350d
disperser test
0x0aa0 Dec 19, 2024
3fad78b
relay test
0x0aa0 Dec 19, 2024
8d28cdf
threshold test
0x0aa0 Dec 19, 2024
ce7e4a4
update blob verify
0x0aa0 Dec 19, 2024
212d29a
v2 verify test
0x0aa0 Dec 19, 2024
637d5ba
nits
0x0aa0 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/src/core/EigenDABlobVerifier.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ contract EigenDABlobVerifier is IEigenDABlobVerifier {
blobVerificationProof,
nonSignerStakesAndSignature,
getDefaultSecurityThresholdsV2(),
quorumNumbersRequired()
blobVerificationProof.blobCertificate.blobHeader.quorumNumbers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already taking blobVerificationProof as input in L96, so looks like we could just reuse that in _verifyBlobV2ForQuorums

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but I do want to leave this field in the internal function open such that the quorums you want to check against can be passed in separately from the proof

);
}

Expand All @@ -118,7 +118,7 @@ contract EigenDABlobVerifier is IEigenDABlobVerifier {
signedBatch,
blobVerificationProof,
getDefaultSecurityThresholdsV2(),
quorumNumbersRequired()
blobVerificationProof.blobCertificate.blobHeader.quorumNumbers
);
}

Expand Down
Loading