Merge pull request #11 from Oppen/perf/rc_tables

perf: use `shared_ptr` for tables
Lartu · Sep 5, 2024 · d501962 · d501962
2 parents be628d3 + 87f1674
commit d501962
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/narivm.cpp b/narivm.cpp
@@ -400,7 +400,7 @@ class Value
     bool has_str_rep;
     string str_rep;
     double num_rep;
-    map<string, Value> *table_rep; // TODO: this is probably a huge memory leak lol
+    shared_ptr<map<string, Value>> table_rep;
     queue<string> *iterator_elements;
 
     void reset_values()
@@ -430,7 +430,7 @@ class Value
     void set_table_value()
     {
         reset_values();
-        this->table_rep = new map<string, Value>();
+        this->table_rep = std::make_shared<map<string, Value>>();
         this->type = TABLE;
     }
 
@@ -460,7 +460,7 @@ class Value
 
     map<string, Value> *get_table()
     {
-        return table_rep;
+        return table_rep.get();
     }
 
     queue<string> *get_iterator_queue()