You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the title indicates, how strict are the rules for code that is under the hood, for instance, I was looking at the bonus that is on Capacity and Experience rings, and because it is int16, going above the value would crash the server, which makes sense because the highest bonus in retail is 30000, https://www.bg-wiki.com/ffxi/Endorsement_Ring as an example. Is changing the int16 in charutils.cpp to int32 so a higher bonus can be applied, something that is acceptable and worth raising a PR for, or is it a no go situation because retails max is clearly below 32,767?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As the title indicates, how strict are the rules for code that is under the hood, for instance, I was looking at the bonus that is on Capacity and Experience rings, and because it is int16, going above the value would crash the server, which makes sense because the highest bonus in retail is 30000, https://www.bg-wiki.com/ffxi/Endorsement_Ring as an example. Is changing the int16 in charutils.cpp to int32 so a higher bonus can be applied, something that is acceptable and worth raising a PR for, or is it a no go situation because retails max is clearly below 32,767?
Beta Was this translation helpful? Give feedback.
All reactions