error with 'python give_items.py`

[jdzwdotnet]

when i run this i get these errors any fixes for that ?

#Loading settings/network.lua
Traceback (most recent call last):
File "C:\New folder\server\tools\give_items.py", line 164, in
main()
~~~~^^
File "C:\New folder\server\tools\give_items.py", line 145, in main
connect()
~~~~~~~^^
File "C:\New folder\server\tools\give_items.py", line 41, in connect
database = credentials["SQL_DATABASE"]
~~~~~~~~~~~^^^^^^^^^^^^^^^^
KeyError: 'SQL_DATABASE'

i havent modified anything in this file, the server itself runs and works as is

[zach2good]

Unlike dbtool, it looks like a lot of these are designed to be run from the tools folder and not the repo root. So CD into the tools folder and run the script from there

[jdzwdotnet]

That’s where i run it from, it’s in the tools folder I had to run it via terminal because if I just open it it closes right away

…

On Sun, Jan 26, 2025 at 6:10 AM Zach Toogood ***@***.***> wrote: Unlike dbtool, it looks like a lot of these are designed to be run from the tools folder and not the repo root. So CD into the tools folder and run the script from there — Reply to this email directly, view it on GitHub <#6851 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BN4ONDUOE5S76EQNRXUNCCL2MTGCBAVCNFSM6AAAAABV4HR6YGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCOJVG43TCMY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[cocosolos]

There's an issue with the regex parsing db credentials. It's a pretty simple fix but for some reason it's still not writing the vars to the db.

server/tools/give_items.py

Lines 37 to 39 in e6e34bb

	match = re.match(r"(SQL_\w+)\s+=\s+(\S+)", line)
	if match:
	credentials[match.group(1)] = match.group(2)

Should be:

            match = re.findall(r"(SQL_\w+)\s*=\s*(?:\"(.*?)\"|([^\"\s,]+)),", line)
            if match:
                credentials[match[0][0]] = match[0][2] if match[0][2] else match[0][1]

Loading settings/network.lua
Connected to database: lsbdb
This Python script allows to give a mog item to the character of your choice
How do you want to assign items?
 1) Single Character
 2) All Characters
Enter name of character: test
Items Available:
1) Nomad Cap
2) Moogle Cap
3) Moogle Rod
4) Harpsichord
5) Stuffed Chocobo
6) Tidal Talisman
7) Destrier Beret
8) Chocobo Shirt

Enter prize to give: 7
Prize distributed!
Closing connection...
Press Enter

However, nothing ends up in the db. Running the query INSERT IGNORE INTO char_vars (charid, varname, value) VALUES ("1", "festiveMoogleDestrierBeret", "1") works fine so not sure what the issue is now.

[cocosolos]

Oh looks like it needs to commit. I'll open a PR.

#6852

[zach2good]

This should be solved with that now-merged PR. If you encounter issues in the future, please open a new issue (and not a discussion)

[zach2good]

As a general reminder, and I've updated the readme to be even clearer than it was before; this should have been an issue and not a discussion.

Crashes, warnings, errors, bugs, gameplay issues, visual issues, etc.
Please create a new issue in the [issues tab](https://github.com/LandSandBoat/server/issues) after searching to see if your issue is already logged.

Balance discussion, technical discussion, meta discussions, etc.
Discussions are similar to forum posts. Please open a new discussion post in the [discussions tab](https://github.com/LandSandBoat/server/discussions) for less directed and more open-ended conversation than issues.

If you are encountering an issue, please open an issue and not a discussion! It's much easier for us to track and you're more likely to get resolution through an issue.