Disable date in log file naming?

[GanimanSwift]

I've noticed recently that log files now have a date in the filename. Is there some way to configure this or disable the date in the file name? This is unnecessary on linux servers that use logrotate, and sort of makes a mess of it if you do. Might be better to provide logrotate configs instead of adding a date to log files. It is very "non-standard" to use this naming convention on linux systems.

Example:

If I start a map server with the flag --log /var/log/xiserver/game-54230.log it changes the log's filename to game-54230_2021-08-14.log. This is not desirable, especially when I am specifying a filename.

If users want to add a date to filenames one way would be to specify the log filename like:

--log /var/log/xiserver/game-54230_$(date +"%y-%m-%d")

[zach2good]

If you're interested in changing how the main logging sink works, you can swap out daily_file_sink_mt for basic_logger_mt here: https://github.com/LandSandBoat/server/blob/base/src/common/logging.cpp#L49

You can also change the logging pattern if needs be: https://github.com/LandSandBoat/server/blob/base/src/common/logging.cpp#L56

We opted to make this change because (more often than not) our average user is running Windows and this is a more common pattern there. If you're more comfortable using Linux, making these changes should be trivial for you.

[GanimanSwift]

It is fine that you want to do things for Windows users, but if a log file location and name is specified on the command line, it should honor that and not change it. It should be a trivial change.

[TeoTwawki]

I have been able to do this using cron(linux) or task scheduler(windows) in combination with a wildcard in my specification of the filename so that the datestamp portion doesn't matter. The datestamp is appended for a reason and specifying it woudl not auto handle it - any crash or restart woudl need you to edit your command line or get the same datestamp again. for years linux support was largely non existent for private servers, and use of logrotate is far from standard, it was made to deal with programs that were shit at logging.

[TeoTwawki]

We broke your specific workflow. Time to make a new one or mod your copy to your desired behavior. It happens.

if you really want it to change in project here in upstream I suggest pull requesting a new --option to control the date append (as previously explained, using the command line to insert the date is not desired, we're bestially trying to automate the date changed log rot for you)

[TeoTwawki]

From discord:

[11:11 PM] Ganiman: you are all toxic

Well good bye then. Never ask me for anything again. You were given the exact changes you'd need to make and a choice, instead because you feel slighted to decided to escalate twice here, the 2nd time to me privately on discord. That behavior is what is toxic and will not be tolerated.