Rabbit sync new

[tatzati]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Documentation (typos, code examples or any documentation update)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• My code follows the style guidelines of this project (scripts/lint.sh has no errors)
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I added a code examples to illustrate the changes

[Lancetnik]

Can you please refactor all the following testcases to use a mocked _connect method instead? We can check incoming *args, **kwargs arguments by assert_called_with method, so we need no more connect to the real broker to test correct arguments merging.

[tatzati]

Is this ok? Or do you have something else in mind?

 @patch("pika.BlockingConnection")
   def test_init_connect(self, mock, settings: Settings):
    mock_conn = MagicMock()
    mock.return_value = mock_conn
    args, kwargs = self.get_broker_args(settings)
    broker = self.broker(*args, **kwargs)
    broker.connect()
    mock.assert_called_once_with(
        pika.URLParameters(settings.url),
    )
    broker.close()
    mock_conn.close.assert_called_once()

[Lancetnik]

I thought about replacing the original broker _connect method to check incoming arguments. It will be suitable for all brokers, not RMQ only

[tatzati]

Can you give me an example?

[Lancetnik]

Tomorrow

[Lancetnik]

By words: you need to patch this one https://github.com/Lancetnik/Propan/blob/main/propan/brokers/rabbit/rabbit_broker.py#L108 the way you patching in the TestBroker
'broker._connect = MethodType(async_mock, broker)' and check the mock call arguments