Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Add BL5340PA #3

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Add BL5340PA #3

merged 3 commits into from
Jul 17, 2024

Conversation

ahedin25
Copy link

@ahedin25 ahedin25 commented Jul 11, 2024

This differs from the rebase onto 2.6.1 because of hardware model v2.

ahedin25 added 2 commits July 10, 2024 15:20
Add BL5340PA board. Uses hardware model v2 that is used by NCS 2.7.0.

PROD-12351

Signed-off-by: Andrew Hedin <andrew.hedin@ezurio.com>
Prevent stack overflow when FEM driver is enabled
that results in an HCI driver open failure (endpoint binding failed).

Bluetooth hci_ipc sample is used by many applications.
The change must also be in this location because it overrides the defconfig.

Signed-off-by: Andrew Hedin <andrew.hedin@ezurio.com>
@ahedin25 ahedin25 requested a review from a team July 12, 2024 13:34
@ahedin25 ahedin25 marked this pull request as ready for review July 12, 2024 13:34
@rerickson1
Copy link
Member

I recommend adding a pa variant of the BL5340 board to reduce maintenance and all the duplicate files.

@dberlin
Copy link

dberlin commented Jul 15, 2024

Just flagging that zephyr accidentally broke the display on the bl5340 when they did MIPI DBI changes,
You've copied the breaking change here.

The mipi_dbi interface spidev should be spi4, not spi2.

It was accidentally? changed from spi4 to spi2 when they updated the bl5340 to use a mipi dbi wrapper.

See zephyrproject-rtos/zephyr#64587 (comment)

(I tested bl5340+lvgl and bl5340pa+lvgl before and after)

Sets the correct SPI device to use when using MIPI display.

Signed-off-by: Andrew Hedin <andrew.hedin@ezurio.com>
Copy link
Member

@rerickson1 rerickson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will look at pa variant later.

@ahedin25 ahedin25 merged commit d60cc29 into bl5340pa/ncs2.7.0 Jul 17, 2024
10 of 13 checks passed
@ahedin25 ahedin25 deleted the PR/v2.7.0 branch July 17, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants