.MAUI

[andersonvieiragomeslopes]

Hi @tompi.

Do you have an upgrade to Maui in mind? If so, do you have a forecast? I estimate the effort to be minimal for the libraries and a bit boring for the example application.

[tompi]

Hey, must admit I am totally green in regards to what is needed for this...

Have you done for any nugets? Ill try running the upgrade-assistant.

The last time I tried using MAUI I was a bit disappointed... didnt seem ready for production, but maybe it changed the last months...

[andersonvieiragomeslopes]

@tompi

maui is very good with .net7 and here is a microsoft migration sample, note that to generate the library the process remains the same and the change is in csproj https://github.com/Azure-Samples/communication-services-ui-library-xamarin/tree/feature/maui

[tompi]

Tried to build for maui now(just ios first), and it seemed painless...
#47

2 things I would like your feedback on:

1. Which namespace should I choose? Maui.AzureCommunicationCalling seems a bit presumptious, but follows the previous Xamarin.AzureCommunicationCalling... Maybe Laerdal.Maui.AzureCommunicationCalling is most correct, but if you are ok with Maui.AzureCommunicationCalling I might just go for that...
2. Should I target .net6 or .net7 ? I guess .net6 is lts, maybe it wont really make a difference?

[tompi]

Hey, I finally got some free time to update these. Stable and beta nugets for Xamarin should be up to date.

Also released beta nugets for maui android.
Didnt do much testing except verifying that expected types are present in the bindings.
Namespaces are not changed, just the package id of nugets and the targeted framework(net6.0-android)

Would appreciate some help testing the MAUI stuff if you have some time!

[tompi]

Btw, I introduced 2 new branches for this, xamarin-stable and maui-beta.

Will add a maui-stable when I see this is working.

So the existing master is xamarin-beta...

[andersonvieiragomeslopes]

Hi, @tompi .

All right, I'll start with the new example for dotnetmaui next week.

[andersonvieiragomeslopes]

Hello @tompi.

I think something is missing, the debug doesn't work properly, I thought I'd add the information for proguard, but the error mentions r8, I'm looking into what that could be.

`-keep class com.skype.rt.** {*;}

-keep class com.azure.** {*;}

-keep class com.skype.android.** {*;}

-keep class com.microsoft.media.** {*;}

-keep class com.microsoft.dl.** {*;}`

[andersonvieiragomeslopes]

I suspect that some dependency is missing.

gson-2.8.6.jar update to https://central.sonatype.com/artifact/com.google.code.gson/gson/2.10.1 or use https://www.nuget.org/packages/GoogleGson

[tompi]

Do you have a branch or repo somewhere? Or did you just ref the droid nuget from a blank maui project?

On Mon, 6 Feb 2023 at 15:51, Anderson Lopes ***@***.***> wrote: I suspect that some dependency is missing. — Reply to this email directly, view it on GitHub <#46 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYSJMBFITLWJUGKVVICPTWWEFVTANCNFSM6AAAAAATLGPLUY> . You are receiving this because you were mentioned.Message ID: <Laerdal/Xamarin. ***@***.***>

-- ***@***.***, 90786985

[andersonvieiragomeslopes]

Hi, @tompi .

Try this: https://github.com/andersonvieiragomeslopes/Xamarin.AzureCommunicationCalling/tree/feature/dotnetmaui

[andersonvieiragomeslopes]

Nuget package ios version 2.3.0-beta.4.1

[tompi]

The android error is a duplication of gson libs, it seems some included androidx lib is also including gson.

I tried recompiling without gson as embedded library reference, but with latest dotnet, im getting a nullpointer exception:

BINDINGSGENERATOR : error BG0000: System.NullReferenceException: Object reference not set to an instance of an object.

(which worked fine a few weeks ago...)

I think maybe I need to wait until Maui is a bit more mature before continuing :(

[tompi]

Just an update: I just updated target of another binding lib im using(nordic dfu) to android 12, and I had to remove inclusion of gson, so mono droid 12(or an androidx-lib) seems to bundle gson. Will attempt this fix for maui once they fix the binding generator.

[kmiterror]

Hi @tompi
First of all thank you big time for creating this nuget package.
It's a shame that Microsoft doesn't support this officially.
But on a side note, what is the progress on this?
It seems like more and more people are moving towards net6.

We also have some experience with library bindings for net6 and in our case we had to enable all legacy options for android in order to make the library work properly

<PropertyGroup>
    <AndroidGenerateResourceDesigner>false</AndroidGenerateResourceDesigner>
    <AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods>false</AndroidBoundInterfacesContainStaticAndDefaultInterfaceMethods>
    <AndroidBoundInterfacesContainTypes>false</AndroidBoundInterfacesContainTypes>
    <AndroidBoundInterfacesContainConstants>false</AndroidBoundInterfacesContainConstants>
  </PropertyGroup>

Maybe it will help in this case also?

[kmiterror]

Hi

Below is our ACSVideoView.cs
PS We use Maui native

public class ACSVideoView : FrameLayout,
        IVideoView,
        ILifecycleObserver

{
        readonly Context _context;
        readonly VideoCallViewModel _viewModel;
        readonly IVideoDelegate _delegate;
        readonly ILogger _logger;

        const float _localVideoViewThumbnailHeight = 180;
        const float _localVideoViewThumbnailWidth = 150;

        private string _consultationKey = string.Empty;
        private string _sessionKey = string.Empty;

        private CallClient? _callClient;
        private CallAgent? _callAgent;
        private DeviceManager? _deviceManager;
        private Call? _call;
        private LocalVideoStream? _localVideoStream;
        private VideoStreamRenderer? _previewRenderer;
        private VideoStreamRendererView? _localVideoView;
        private VideoStreamRendererView? _remoteVideoView;

        bool _isCameraDisabled;
        public bool IsCameraDisabled
        {
            get => _isCameraDisabled;
            set
            {
                _isCameraDisabled = value;
                SetCameraDisabled(_isCameraDisabled);
            }
        }

        bool _isMicrophoneDisabled;
        public bool IsMicrophoneDisabled
        {
            get => _isMicrophoneDisabled;
            set
            {
                _isMicrophoneDisabled = value;
                SetMicrophoneDisabled(_isMicrophoneDisabled);
            }
        }


        public ACSVideoView(Context context, IVideoDelegate @delegate, VideoCallViewModel viewModel) : base(context)
        {
            _context = context;
            _viewModel = viewModel;
            _delegate = @delegate;
            _logger = Mvx.IoCProvider.Resolve<ILogger<ACSVideoView>>();

            ProcessLifecycleOwner.Get().Lifecycle.AddObserver(this);
        }

        public Task Configure(CallModel callInfo)
        {
            if (callInfo.VideoSession == null) throw new NullReferenceException("CallInfo.VideoSession was unexpectedly null");

            _consultationKey = callInfo.VideoSession.ConsultationUid.ToShortString();
            _sessionKey = callInfo.VideoSession.Uid.ToShortString();

            _callClient = new CallClient();

            var credentials = new CommunicationTokenCredential(callInfo.AzureVideoCallToken) ?? throw new NullReferenceException();
            var options = new CallAgentOptions();
            options.SetDisplayName(callInfo.DisplayName);
            _callAgent = CallClientHelper.GetCallAgent(_callClient, _context, credentials, options);

            _deviceManager = CallClientHelper.GetDeviceManager(_callClient, _context);
            _deviceManager.CamerasUpdated += CamerasUpdated;

            return ConnectToCall(callInfo.VideoSession.ConsultationUid);
        }

        public void CycleCamera()
        {
            if (_localVideoStream == null) return;

            CameraFacing newCamera = _localVideoStream.Source.CameraFacing == CameraFacing.Front
                ? CameraFacing.Back
                : CameraFacing.Front;

            var switchCurrentCamera = _deviceManager?.Cameras.Where(c => c.CameraFacing == newCamera).FirstOrDefault();
            if (switchCurrentCamera != null)
            {
                CallClientHelper.SwitchCameraSource(_localVideoStream, switchCurrentCamera);
            }
        }

        public void RefreshUIOnConfigurationChanged(int bottomPadding, int topPadding)
        {
            // Legacy method required by vidyo
        }

        protected override void Dispose(bool disposing)
        {
            if (disposing)
            {
                if (_call != null)
                {
                    _call.RemoteParticipantsUpdated -= RemoteParticipantsUpdated;
                    CallClientHelper.HangUp(_call, new HangUpOptions());
                    _call.Dispose();
                    _call = null;
                }

                if (_deviceManager != null)
                {
                    _deviceManager.CamerasUpdated -= CamerasUpdated;
                    _deviceManager.Dispose();
                    _deviceManager = null;
                }

                _previewRenderer?.Dispose();
                _previewRenderer = null;
                _localVideoStream?.Dispose();
                _localVideoStream = null;
                RemoveAllViews();
                _remoteVideoView = null;
                _localVideoView = null;

                ProcessLifecycleOwner.Get().Lifecycle.RemoveObserver(this);
            }

            base.Dispose(disposing);
        }

        [Lifecycle.Event.OnStart]
        [Export]
        public void OnStart()
        {
            _logger.LogTrace($"ACSVideoView OnStart cid={_consultationKey} sid={_sessionKey}");
            if (_call == null) return;
            SetCameraDisabled(_isCameraDisabled);
        }

        [Lifecycle.Event.OnStop]
        [Export]
        public void OnStop()
        {
            _logger.LogTrace($"ACSVideoView OnStop cid={_consultationKey} sid={_sessionKey}");
            if (_call == null) return;
            SetCameraDisabled(true);
        }

        private Task ConnectToCall(Guid consultationUid)
        {
            if (_deviceManager?.Cameras.Count() > 0)
            {
                var videoDeviceInfo = _deviceManager.Cameras
                    .Where(c => c.CameraFacing == CameraFacing.Front).FirstOrDefault()
                    ?? _deviceManager.Cameras.FirstOrDefault();

                if (videoDeviceInfo != null)
                {
                    _localVideoStream = new LocalVideoStream(videoDeviceInfo, _context);
                    _previewRenderer = new VideoStreamRenderer(_localVideoStream, _context);
                    _localVideoView = _previewRenderer.CreateView(new CreateViewOptions(ScalingMode.Crop));
                    AddView(_localVideoView);

                    JoinCallOptions? joinCallOptions = new();
                        joinCallOptions
                        .SetAudioOptions(new AudioOptions())
                        .SetVideoOptions(new VideoOptions(
                            new LocalVideoStream[] { _localVideoStream }
                            ));

                    var consultationUuid = UUID.FromString(consultationUid.ToString());
                    var groupCallLocator = new GroupCallLocator(consultationUuid);

                    _call = _callAgent?.Join(_context, groupCallLocator, joinCallOptions);

                    if (_call != null)
                    {
                        _call.RemoteParticipantsUpdated += RemoteParticipantsUpdated;
                    }
                }
            }
            else
            {
                _logger.LogDebug($"No camera found on device cid={_consultationKey} sid={_sessionKey} platform={DeviceInfo.Platform} manufacturer={DeviceInfo.Manufacturer} model={DeviceInfo.Model} OS version={DeviceInfo.VersionString}");
            }

            return Task.CompletedTask;
        }

        private void RemoteParticipantsUpdated(object sender, ParticipantsUpdatedEventArgs e)
        {
            foreach (var participantAdded in e.P0.AddedParticipants)
            {
                participantAdded.VideoStreamsUpdated += RemoteVideoStreamsUpdated;            

                _logger.LogDebug($"Participant joined cid={_consultationKey} sid={_sessionKey} participant={participantAdded.Identifier}");
                _viewModel.OnParticipantJoined(participantAdded.DisplayName);
            }

            foreach(var participantRemoved in e.P0.RemovedParticipants)
            {
                _logger.LogDebug($"Participant left cid={_consultationKey} sid={_sessionKey} participant={participantRemoved.Identifier}");
                _viewModel.OnParticipantLeft(participantRemoved.DisplayName);
            }
        }

        private void RemoteVideoStreamsUpdated(object sender, RemoteVideoStreamsUpdatedEventArgs e)
        {
            if (sender is not RemoteParticipant) return;

            foreach (var stream in e.P0.AddedRemoteVideoStreams)
            {
                if (stream.State == VideoStreamState.Available)
                {
                    AddRemoteVideo(stream);
                }
            }

            foreach (var stream in e.P0.RemovedRemoteVideoStreams)
            {
                RemoveRemoteVideo();
            }
        }

        private void AddRemoteVideo(RemoteVideoStream v)
        {
            var renderer = new VideoStreamRenderer(v, _context);
            var renderingOptions = new CreateViewOptions(ScalingMode.Crop);
            _remoteVideoView = renderer.CreateView(renderingOptions);
            MainThread.BeginInvokeOnMainThread(() => {
                AddViewInLayout(_remoteVideoView, 0, new ViewGroup.LayoutParams(LayoutParams.MatchParent, LayoutParams.MatchParent));
                UpdateLocalVideoViewAppearance(LocalVideoViewAppearance.Thumbnail);
            });
        }

        private void RemoveRemoteVideo()
        {
            MainThread.BeginInvokeOnMainThread(() => {
                if (_remoteVideoView == null) return;

                RemoveView(_remoteVideoView);
                UpdateLocalVideoViewAppearance(LocalVideoViewAppearance.Fullscreen);
            });
        }

        private void UpdateLocalVideoViewAppearance(LocalVideoViewAppearance appearance)
        {
            if (_localVideoView == null) return;

            var shape = new GradientDrawable();
            ViewGroup.LayoutParams layoutParams;

            switch (appearance)
            {
                case LocalVideoViewAppearance.Thumbnail:
                {
                    shape.SetCornerRadius(16f.GetDip(Context));

                    layoutParams = new LayoutParams(
                            _localVideoViewThumbnailWidth.GetDip(_context),
                            _localVideoViewThumbnailHeight.GetDip(_context))
                    {
                        Gravity = GravityFlags.Bottom | GravityFlags.Right,
                        BottomMargin = Dimensions.SpacingXXSmall.GetDip(Context),
                        TopMargin = Dimensions.SpacingXXSmall.GetDip(Context),
                        LeftMargin = Dimensions.SpacingXXSmall.GetDip(Context),
                        RightMargin = Dimensions.SpacingXXSmall.GetDip(Context)
                    };
                    break;
                }
                case LocalVideoViewAppearance.Fullscreen:
                {
                    layoutParams = new LayoutParams(LayoutParams.MatchParent, LayoutParams.MatchParent);
                    break;
                }
                default:
                    throw new ArgumentOutOfRangeException($"Unknown {nameof(LocalVideoViewAppearance)}");
            }

            _localVideoView.Background = shape;
            _localVideoView.LayoutParameters = layoutParams;
        }

        private void SetCameraDisabled(bool isCameraDisabled)
        {
            if (_call == null || _localVideoStream == null) return;

            if (isCameraDisabled)
            {
                RemoveView(_localVideoView);
                CallClientHelper.StopVideo(_call, _localVideoStream, _context);
            }
            else
            {
                CallClientHelper.StartVideo(_call, _localVideoStream, _context);
                AddView(_localVideoView);
            }
            _logger.LogInformation($"SetCameraDisabled cid={_consultationKey} sid={_sessionKey} cameraoff={isCameraDisabled}");
        }

        private void SetMicrophoneDisabled(bool isMicrophoneDisabled)
        {
            if (_call == null) return;

            if (isMicrophoneDisabled)
            {
                CallClientHelper.Mute(_call, _context);
            }
            else
            {
                CallClientHelper.UnMute(_call, _context);
            }
            _logger.LogInformation($"SetMicrophoneDisbled cid={_consultationKey} sid={_sessionKey} mute={isMicrophoneDisabled}");
        }

        private void CamerasUpdated(object sender, VideoDevicesUpdatedEventArgs e)
        {
            if (_deviceManager == null) return;

            var numberOfCameras = _deviceManager.Cameras.Count();

            foreach (var camera in e.P0.AddedVideoDevices)
            {
                _logger.LogDebug($"Added local camera cid={_consultationKey} sid={_sessionKey} camera={camera.Name} count={numberOfCameras}");
            }

            foreach (var camera in e.P0.AddedVideoDevices)
            {
                _logger.LogDebug($"Removed local camera cid={_consultationKey} sid={_sessionKey} camera={camera.Name} count={numberOfCameras}");
            }

            _delegate.NumberOfCamerasUpdated(numberOfCameras);
        }
    }

[andersonvieiragomeslopes]

Hey @kmiterror ! I have finally started porting our app that uses ACS to MAUI, and it is not a walk in the park... For the ACS part on Android, Im getting an exception when trying to set the convert the local video renderer view to the Content of a ContentView:

Handler not found for view Microsoft.Maui.Controls.Compatibility.Platform.Android.NativeViewWrapper.

Could I trouble you for your code for setting up the video view?

Edit, if you want fame and glory, you could answer my SO post: https://stackoverflow.com/questions/78001254/adding-platform-view-to-maui-contentview-during-runtime :)

I have the same problem on Windows, on mobile I decided to use another Microsoft SDK for VoIP which has the screens ready, it's bad, but it was the only solution I found due to this problem with ToView().
I believe that this item was removed or they didn't want to implement it, I didn't find any alternative solution, without this item it is impossible to have video calls and screen sharing.

This sounds like the same problem you are experiencing.
dotnet/maui#7720

[tompi]

I actually found a workaround, that at least works on android. Gonna continue on ios now.

I just created a new custom view with a public property(object) for the actual native view. Then I registered a handler for this, which just creates an Android frameview, and adds the native view to children when its set.

Took me some hours to figure out, and much more code than the nice .Content = v.ToView()....

I can send you complete files if you want to try the same on win...

[tompi]

Thank you @kmiterror , I guess you wont have the same issue on native, but nice of you to post code, might come in handy!

[kmiterror]

@tompi
Recently we are trying to migrate to net8.
Video call works fine on iOS, but on android it's crashing.
Can you compile package against net8-android TFM?
Also last time I tried I couldn't get to compile android lib, could you walk me through the process?
Perhaps we could hop on a call?

[kmiterror]

Great work guys.
Thanks for the effort to both of you.
I will have a look sometime next week if it works in my case also.
Once again thanks.

[tompi]

Great News! Thank you

…

On Tue, 5 Dec 2023 at 16:00, kmiterror ***@***.***> wrote: Ok I got it working, The problem was that the AzureCommunicationCommon.framework in Pods was a symlink. Apparently dotnet has a bug and included symlink in the nuget package instead of the content of the folder that symlink is pointing to. Once I deleted symlink and copied the folder manually from nativeLibs/Pods/_Prebuild/AzureCommunicationCommon the AzureCommunicationCommon.framework was properly included in the nuget package. I tested this and the package: - builds without errors now - works on iOS simulator (ARM CPU, I haven't tested x86 yet, I will report tomorrow) - CallDelegate issue that I previously reported is gone Tomorrow I will do some cleanup, and I can prepare a PR and perhaps @tompi <https://github.com/tompi> can publish new package image.png (view on web) <https://github.com/Laerdal/Xamarin.AzureCommunicationCalling/assets/4394164/77fb14da-bd70-44f3-9698-f7302a2d4a1c> — Reply to this email directly, view it on GitHub <#46 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYSJKEHPCM4TG4OQPF3H3YH4ZHRAVCNFSM6AAAAAATLGPLU2VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TONRVGYZDK> . You are receiving this because you were mentioned.Message ID: <Laerdal/Xamarin. ***@***.***>

[tompi]

hey, its working on android on net8 for me. Are you using 2.6.0-beta.5.4? <PackageReference Include="Laerdal.Maui.AzureCommunicationCalling.android" Version="2.6.0-beta.5.4" Condition="'$(TargetFramework)' == 'net8.0-android'" /> <PackageReference Include="Laerdal.Maui.AzureCommunicationHelper.android" Version="2.6.0-beta.5.2" Condition="'$(TargetFramework)' == 'net8.0-android'" /> A call would be fun, im in Norway, UTC+2 Thomas Haukland Software Developer Consultant Laerdal Medical — Stavanger, Norway ​www.laerdal.com This e-mail and any attachments thereto may contain confidential information and/or information protected by intellectual property rights for the exclusive attention of the intended addressees named above. If you have received this transmission in error, please immediately notify the sender by return e-mail and delete this message and its attachments. Unauthorized use, copying or further full or partial distribution of this e-mail or its contents is prohibited. While attachments to this e-mail are checked for viruses, Laerdal does not accept any liability for any damage caused by viruses. For more information on how we process personal data please see https://www.laerdal.com/support/customer-service/privacy-policy/ ED8rMQMmKR5nxVH

…

________________________________ From: kmiterror ***@***.***> Sent: 24 April 2024 17:53 To: Laerdal/Xamarin.AzureCommunicationCalling ***@***.***> Cc: Thomas Haukland ***@***.***>; Mention ***@***.***> Subject: Re: [Laerdal/Xamarin.AzureCommunicationCalling] .MAUI (Discussion #46) @tompi<https://github.com/tompi> Recently we are trying to migrate to net8. Video call works fine on iOS, but on android it's crashing. Can you compile package against net8-android TFM? Also last time I tried I couldn't get to compile android lib, could you walk me through the process? Perhaps we could hop on a call? — Reply to this email directly, view it on GitHub<#46 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABYSJJ3KLJMUUDQH4AMCFDY67IPLAVCNFSM6AAAAAATLGPLU2VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TEMJVGQ4DG>. You are receiving this because you were mentioned.

[kmiterror]

I just tried with 2.6.0-beta.5.4 but it still crashes.
What targetSdkVersion you have in AndroidManifest.xml?
Mine is 34 (it works if I would set it to 33)

[tompi]

yep, I have 33... I can try compiling for net8 as well, started doing it now, fighting with some chrono-errors in threetenabp while updating azurecore... Looking into it Thomas Haukland Software Developer Consultant Laerdal Medical — Stavanger, Norway ​www.laerdal.com This e-mail and any attachments thereto may contain confidential information and/or information protected by intellectual property rights for the exclusive attention of the intended addressees named above. If you have received this transmission in error, please immediately notify the sender by return e-mail and delete this message and its attachments. Unauthorized use, copying or further full or partial distribution of this e-mail or its contents is prohibited. While attachments to this e-mail are checked for viruses, Laerdal does not accept any liability for any damage caused by viruses. For more information on how we process personal data please see https://www.laerdal.com/support/customer-service/privacy-policy/ ED8rMQMmKR5nxVH

…

________________________________ From: kmiterror ***@***.***> Sent: 25 April 2024 09:23 To: Laerdal/Xamarin.AzureCommunicationCalling ***@***.***> Cc: Thomas Haukland ***@***.***>; Mention ***@***.***> Subject: Re: [Laerdal/Xamarin.AzureCommunicationCalling] .MAUI (Discussion #46) I just tried with 2.6.0-beta.5.4 but it still crashes. What targetSdkVersion you have in AndroidManifest.xml? Mine is 34 (it works if I would set it to 33) — Reply to this email directly, view it on GitHub<#46 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABYSJOH4SMJYOD7FRBSANLY7CVPPAVCNFSM6AAAAAATLGPLU2VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TEMRRGY2DK>. You are receiving this because you were mentioned.Message ID: ***@***.***>