Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaced attributes break XHTML parsing #3137

Open
AtkinsSJ opened this issue Jan 4, 2025 · 0 comments · May be fixed by #3138
Open

Namespaced attributes break XHTML parsing #3137

AtkinsSJ opened this issue Jan 4, 2025 · 0 comments · May be fixed by #3138
Labels
bug Something isn't working has repro We have a way to reproduce this bug. xml

Comments

@AtkinsSJ
Copy link
Member

AtkinsSJ commented Jan 4, 2025 •
edited
Loading

This produces only "well" in Ladybird, but the full text shows up in other browsers.

The foo:bar is the issue.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:foo="http://www.example.com">
<body>
<div>well</div>
<div foo:bar="FAIL">hello</div>
<div>friends</div>
</body>
</html>

No messages appear in the logs.
@AtkinsSJ AtkinsSJ added bug Something isn't working has repro We have a way to reproduce this bug. xml labels Jan 4, 2025
alimpfard added a commit to alimpfard/ladybird that referenced this issue Jan 4, 2025
@alimpfard
LibWeb/XML: Set attributes using Element::set_attribute_ns
4ad3c57 
Otherwise we'd end up ignoring attr prefixes and treating them as part
of the attribute's local name.
Fixes LadybirdBrowser#3137.
@alimpfard alimpfard linked a pull request Jan 4, 2025 that will close this issue
Draft
alimpfard added a commit to alimpfard/ladybird that referenced this issue Jan 4, 2025
@alimpfard
LibWeb/XML: Set attributes using Element::set_attribute_ns
37ddaff 
Otherwise we'd end up ignoring attr prefixes and treating them as part
of the attribute's local name.
Fixes LadybirdBrowser#3137.

This is a partial revert of b3fdeef,
but it fixes the underlying issue that it was working around.
alimpfard added a commit to alimpfard/ladybird that referenced this issue Jan 4, 2025
@alimpfard
LibWeb/XML: Set non-local attributes using Element::set_attribute_ns
c15ae4e 
Otherwise we'd end up ignoring attr prefixes and treating them as part
of the attribute's local name.
Fixes LadybirdBrowser#3137.

This is a partial revert of b3fdeef,
but it fixes the underlying issue that it was working around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has repro We have a way to reproduce this bug. xml
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb/XML: Set attributes using Element::set_attribute_ns alimpfard/ladybird
1 participant
@AtkinsSJ