Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested learning objective headers #1693

Merged
merged 17 commits into from
Jan 25, 2024

Conversation

unjust
Copy link
Contributor

@unjust unjust commented Jan 5, 2024

Addresses #1650

Need to try again because it looks like github strips styles in markdown
https://github.com/Laboratoria/OA-TEST-fleet-management-api/blob/main/README.md

This one may be better, adds text to headings deeper in the hierarchy
https://github.com/Laboratoria/OA-TEST2-fleet-management-api/blob/main/README.md

Example with md links
https://github.com/Laboratoria/OA-TEST-md-links

@unjust unjust self-assigned this Jan 5, 2024
@unjust unjust marked this pull request as ready for review January 8, 2024 19:14
@unjust unjust linked an issue Jan 8, 2024 that may be closed by this pull request
5 tasks
@unjust unjust requested review from mfdebian and ssinuco January 8, 2024 22:10
@unjust unjust added the enhancement New feature or request label Jan 8, 2024
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Gracias @unjust ! 😊

Perdón la demora, es harto código que revisar, y me toca ir poniéndole algunos console.log para poder irlo entendiendo bien 🙈

Tengo sólo una duda, veo que en el comentario que dejaste hay un link hacia el README de un proyecto (md-links), en ese README se ve de esta forma:

Screenshot_2024-01-15_11-32-00

Pero al ejecutar el comando en mi local con los cambios, se despliega esto:

ES:

Screenshot_2024-01-15_11-33-06

PT:

Screenshot_2024-01-15_11-33-32

Me imagino que la intención es que, en vez de que diga js/data-types o js/modules, contenga su correcta traducción en cada lenguaje, será que falta algo en el PR para que se despliegue como el README que compartes? avísame! En cualquier caso, se ve bien y creo que es un cambio necesario, asegurándonos que funciona y se comporta como debe lo aprobamos nomas! 🙋‍♂️

@unjust
Copy link
Contributor Author

unjust commented Jan 15, 2024

@mfdebian falte un dependencia #1209 que he mergeado a next la semana pasada. Ahora si jalas y quieres probar de nuevo, me imaginas que va a tener los titulos.

mfdebian
mfdebian previously approved these changes Jan 16, 2024
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

Dejé sólo un comentario a modo de sugerencia en una función en la cual había una variable q no se estaba utilizando, siéntete libre de agregarla o no, no cambia el output, y los tests siguen pasando.

Mil, mil gracias @unjust por el trabajo y por haberle agregado tests 🤗 🥳

scripts/script-utils.mjs Outdated Show resolved Hide resolved
Co-authored-by: Alfredo González <12631491+mfdebian@users.noreply.github.com>
@unjust
Copy link
Contributor Author

unjust commented Jan 19, 2024

Thanks @mfdebian will self approve and merge this after the UX release.

@unjust unjust added this to the 8.1 milestone Jan 24, 2024
@unjust unjust merged commit baa581c into Laboratoria:next Jan 25, 2024
4 checks passed
@unjust unjust deleted the add_oas_nested_headers_1650 branch January 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibilizar OAs nido con sus encabezados en los proyectos
2 participants