Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process swww args even with --no-daemon #218

Closed
wants to merge 1 commit into from

Conversation

musjj
Copy link
Contributor

@musjj musjj commented Feb 21, 2024

This PR makes it so that swww args gets processed even when you pass --no-daemon to it. This ensures that your cached wallpaper will get loaded when you run swww init --no-daemon.

Fix: #217

@LGFae
Copy link
Owner

LGFae commented Feb 21, 2024

The check failing is a false positive; don't worry about it.

@musjj
Copy link
Contributor Author

musjj commented Feb 21, 2024

Never mind, this doesn't work when run as a service on startup. Apparently, this is a known issue: #144 (comment).

For now I'm closing it, because this will be a regression for those who are using it as a service.

@musjj musjj closed this Feb 21, 2024
@LGFae
Copy link
Owner

LGFae commented Feb 21, 2024

Ah yes, I remember now. I think the problem is that the compositor needs to set up some stuff, and when we run swww too early during initialization the compositor might not have yet finished setting up the environment. This would explain why putting sleep before calling swww init --no-daemon seems to solve the problem for some people. In any case, I don't really know how to solve this yet...

@musjj
Copy link
Contributor Author

musjj commented Feb 21, 2024

Yeah, for now I think a better solution would be a command to load the cache explicitly: #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache is not used with --no-daemon
2 participants