-
Notifications
You must be signed in to change notification settings - Fork 89
feat: handle empty stack in preview #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
And the CI failed! |
@@ -200,9 +200,12 @@ func (m *StackManager) PreviewStack(ctx context.Context, params *StackRequestPar | |||
|
|||
// return immediately if no resource found in stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change these comments in code. (line 201~line 202)
Please ignore And Constraints / Commit Lint (pull_request) is about your commit message, rewrite to |
@7h3-3mp7y-m4n By the way, you need to sign the CLA according to the description here, otherwise the PR will not be accepted. 😃 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
It is actually valid to pass an empty spec for a preview, and Kusion should handle the preview result correctly.
This change should not affect how apply and destroy handle an empty spec.
Which issue(s) this PR fixes:
Fixes #1419
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: