Fix: Properly handle DOM content loaded event (#32)

* Properly handle DOM content loaded event * Properly handle DOM content loaded event * Remove def Co-authored-by: Rob Dick <r.dick@kumulos.com>
Kumulos · May 19, 2021 · 03b3d0c · 03b3d0c
1 parent b575ea8
commit 03b3d0c
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 8 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/worker.js b/dist/worker.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@kumulos/web",
-    "version": "1.7.1",
+    "version": "1.7.2",
     "description": "Official SDK for integrating Kumulos services with your web projects",
     "main": "dist/index.js",
     "types": "types/src/index.d.ts",
@@ -42,4 +42,4 @@
     "dependencies": {
         "preact": "^10.5.13"
     }
-}
+}
diff --git a/src/core/index.ts b/src/core/index.ts
@@ -2,7 +2,7 @@ import { authedFetch, cyrb53, uuidv4 } from './utils';
 import { del, get, set } from './storage';
 import { Channel } from './channels';
 
-const SDK_VERSION = '1.7.1';
+const SDK_VERSION = '1.7.2';
 const SDK_TYPE = 10;
 const EVENTS_BASE_URL = 'https://events.kumulos.com';
 export const PUSH_BASE_URL = 'https://push.kumulos.com';

diff --git a/src/core/utils.ts b/src/core/utils.ts
@@ -183,3 +183,11 @@ export function parseQueryString(
 
     return query;
 }
+
+export function onDOMReady(fn: () => void) {
+    if (document.readyState !== 'loading') {
+        fn();
+    } else {
+        document.addEventListener('DOMContentLoaded', fn);
+    }
+}
diff --git a/src/prompts/index.tsx b/src/prompts/index.tsx
@@ -26,6 +26,7 @@ import { persistPromptReminder, getPromptReminder } from '../core/storage';
 import { PromptReminderDelayConfig } from '../core';
 import { UIContext } from './ui-context';
 import { loadConfig } from '../core/config';
+import { onDOMReady } from '../core/utils';
 
 export type PromptManagerState =
     | 'loading'
@@ -74,7 +75,7 @@ export class PromptManager {
 
         ctx.subscribe('eventTracked', this.onEventTracked);
 
-        document.addEventListener('DOMContentLoaded', () => {
+        onDOMReady(() => {
             document.body.appendChild(this.uiRoot);
             this.setState('loading');
         });

diff --git a/types/src/core/utils.d.ts b/types/src/core/utils.d.ts
@@ -16,3 +16,4 @@ export declare function defer<T>(): {
 export declare function parseQueryString(qs?: string, excludedQueryKeys?: string[]): {
     [key: string]: string;
 } | undefined;
+export declare function onDOMReady(fn: () => void): void;