Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dice): New dice features & changes #1455

Merged
merged 20 commits into from
Aug 24, 2024
Merged

feat(dice): New dice features & changes #1455

merged 20 commits into from
Aug 24, 2024

Conversation

Kruptein
Copy link
Owner

This is a big PR that reworks a lot of the dice code.

Technical changes

Notably, babylonjs (the 3d engine PA uses for the dice rolls) was upgraded from version 4 to 7.
This also changes the underlying physics engine from ammo to havok.

@planarally/dice has seen a huge restructure + rework of logic.

More changes to the dice repo are expected in the near future, 1 avenue I might be considering is to move all or most of the dice code inside of the core repo to the dice repo and have dice become a PA mod instead of being bundled with the main bundle.

New UI

The dice tool UI has changed big time as a whole set of new clicky options is available to configure dice rolls with more advanced things you might be used to from other tools. (e.g. "keep highest 1").

Another noticeable new thing, is that now there is a switch to enable or disable the use of 3D dice.
By default no 3D will be used, and results will just be generated on the fly, allowing quick and light dice rolling.

The 3D assets and files will not load until you've flipped the 'use 3D' switch once.

The roll history has a slightly different UI, clicking on an entry will show the roll details again.
Similarly clicking on a notification that reports another player's roll, will do the same.

@Kruptein Kruptein force-pushed the feature/dice-ui-rework branch 3 times, most recently from 54d3632 to 51b50a1 Compare August 12, 2024 17:03
@Kruptein Kruptein force-pushed the feature/dice-ui-rework branch from e9534f5 to 1f6e3d9 Compare August 24, 2024 12:40
@Kruptein Kruptein merged commit 2826074 into dev Aug 24, 2024
5 checks passed
@Kruptein Kruptein deleted the feature/dice-ui-rework branch August 24, 2024 12:42
@develroo
Copy link

Cool stuff.. But are we any closer to deciding on a d100 solution? ;)

@develroo
Copy link

Hmm Just tested it. Looks good.. But aren't the settings supposed to stick between each activation ? Seem if I click to any tool and then back to dice, it resets to no 3D dice and Share with all. That could get annoying pretty quick if you roll without thinking.

@Kruptein
Copy link
Owner Author

Cool stuff.. But are we any closer to deciding on a d100 solution? ;)

I assume you mean rolling a d10 as well? that's on my todos as well indeed :)

Hmm Just tested it. Looks good.. But aren't the settings supposed to stick between each activation ? Seem if I click to any tool and then back to dice, it resets to no 3D dice and Share with all. That could get annoying pretty quick if you roll without thinking.

Ah thanks for the feedback, that's not supposed to happen indeed

@develroo
Copy link

I assume you mean rolling a d10 as well? that's on my todos as well indeed :)

Ahh cool I see a d100 (10s) and so a d10 + d100 = % die

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants