Skip to content

Commit

Permalink
fix compatiblity for Cura 4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@Kriechi
Kriechi committed Jan 5, 2019
1 parent 0c2f003 commit 2038382
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions plugin.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"description": "Upload and Print to DuetWifi / DuetEthernet / Duet Maestro with RepRapFirmware.",
"version": "1.0.1",
"minimum_cura_version": "3.5",
"maximum_cura_version": "3.6",
"api": 5
"maximum_cura_version": "4.0",
"api": "6.0"
}

6 comments on commit 2038382

@fieldOfView
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the api to "6.0" makes the plugin not work for Cura 3.6. See this thread about making plugins that are compatible with multiple Cura versions:
Ultimaker/Uranium#460 (comment)

Also note that the "minimum_cura_version" and "maximum_cura_version" are not used by Cura. They have no meaning, unless the plugin itself looks at these keys. I added them to some of my plugins as a meassure to make sure my plugins don't blow up Cura when used with untested versions of Cura. See https://github.com/fieldOfView/Cura-OctoPrintPlugin/blob/3.5/__init__.py#L31

@Kriechi
Copy link
Owner Author

@Kriechi Kriechi commented on 2038382 Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the API version: I thought the Marketplace re-generates the plugin.json file anyway and substitutes the correct one? So currently only people that want to install from my git-source might have problems...

About the cura-version: thanks - I can probably get rid of them. I'm not using them anywhere.

@Kriechi
Copy link
Owner Author

@Kriechi Kriechi commented on 2038382 Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind - I actually had some changes already lined up, but not pushed yet.
Would you mind checking with latest master again?

Thanks for the feedback!

@fieldOfView
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The marketplace backend does not touch your plugin.json, but adds a package.json

@fieldOfView
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now. The reason I looked into your repo was this issue: Ultimaker/Cura#5262, not sure if you had seen it.

@Kriechi
Copy link
Owner Author

@Kriechi Kriechi commented on 2038382 Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - no I haven't seen that issue. I'll test and comment there.

Please sign in to comment.