Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Update minimum cmake required version #13189

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[Draft] Update minimum cmake required version #13189

merged 1 commit into from
Mar 6, 2025

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Mar 4, 2025

No description provided.

@rfaasse
Copy link
Contributor Author

rfaasse commented Mar 4, 2025

@roigcarlo Created this draft PR, it seems the pipelines are fine with 3.15 (we might consider moving up a bit more)

roigcarlo
roigcarlo approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Since everything passes.

My target would be 3.24, but seems to have problems, let's merge this for now

@rfaasse rfaasse marked this pull request as ready for review March 6, 2025 08:59
@rfaasse rfaasse requested a review from a team as a code owner March 6, 2025 08:59
@rfaasse rfaasse merged commit dc485cb into master Mar 6, 2025
11 checks passed
@rfaasse rfaasse deleted the core/upgrade-cmake-minimum-required-version branch March 6, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roigcarlo roigcarlo roigcarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfaasse @roigcarlo