Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Revisit the 1D consolidation benchmark test's python file #12167

Merged
merged 11 commits into from
Mar 12, 2024
Merged

[GeoMechanicsApplication] Revisit the 1D consolidation benchmark test's python file #12167

merged 11 commits into from
Mar 12, 2024

Conversation

markelov208
Copy link
Contributor

📝 Description
A brief description of the PR.

Check displacement results and produce graph results for water pressure and displacement. Results are compared with the Verruijt analytical solution.

🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.

  • added creation of water pressure and displacement pictures in svg format. This requires matplotlib.
  • added function to calculate a total deformation following the Verruijt analytical solution.
  • added asserts for displacement/deformation
  • extended documentation

Gennady Markelov added 6 commits March 9, 2024 22:54
revisit 1d consolidation test
725aab4 
- added creation of displacement and water pressure pictures in svg format
- added checking of displacement
- added calculation of degree of consolidation
fixed equations
2b13a9e
fixed Solution
90e0cbd
extended description of assertions
dd871c5
Merge branch 'master' into geo/revisit_1d_consolidation_benchmark_test
ba58552
changes
db6513c 
- a new name calculate_degree_of_1D_consolidation in analytical_solutions
- moved 1d_consolidation test in a separate py file
- removed calls to matplotlib
@markelov208 markelov208 requested review from WPK4FEM and rfaasse March 12, 2024 06:40
rfaasse
rfaasse reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extension of this test to include the analytical result for the displacements. The plots improve the clarity of the test a lot, thanks for adding them!

I have a few suggestions for improvements, nothing really blocking (except the unfortunate need to skip this test until we have found the issue with it in the pipeline)

@rfaasse rfaasse mentioned this pull request Mar 12, 2024
Closed
@WPK4FEM WPK4FEM linked an issue Mar 12, 2024 that may be closed by this pull request
[GeoMechanicsApplication] Revisit the 1D consolidation benchmark test's python file #12170
Closed
WPK4FEM
WPK4FEM reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for completing this example of our geomechanics functionality.

markelov208
markelov208 commented Mar 12, 2024
View reviewed changes
Copy link
Contributor Author

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks Richard and Wijtze-Pieter for many fruitful and important comments.

@WPK4FEM WPK4FEM self-requested a review March 12, 2024 15:29
rfaasse
rfaasse approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the changes, all good from my side!

WPK4FEM
WPK4FEM approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the good effort. For me this is ready to merge.

@markelov208 markelov208 merged commit 9c0870a into master Mar 12, 2024
15 of 16 checks passed
@markelov208 markelov208 deleted the geo/revisit_1d_consolidation_benchmark_test branch March 12, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfaasse rfaasse rfaasse approved these changes

@WPK4FEM WPK4FEM WPK4FEM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Revisit the 1D consolidation benchmark test's python file
3 participants
@markelov208 @rfaasse @WPK4FEM