[OptApp] Add filtering factory #12142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate_filtering_factory
Igarizza
reviewed
Mar 5, 2024
applications/OptimizationApplication/tests/test_OptimizationApplication.py
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/tests/filtering/explicit_filters_tests.py
Show resolved
Hide resolved
applications/OptimizationApplication/python_scripts/filtering/explicit_vertex_morphing.py
Show resolved
Hide resolved
applications/OptimizationApplication/custom_utilities/filtering/filter_function.cpp
Outdated
Show resolved
Hide resolved
applications/OptimizationApplication/custom_utilities/filtering/filter_function.cpp
Outdated
Show resolved
Hide resolved
…g/filter_function.cpp Co-authored-by: IAntonau <igor.antonov92@gmail.com>
RezaNajian
requested changes
Mar 6, 2024
|
Closing in favor of #12201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds filtering factory which can be used among any controller. At the moment, this only supports explicit filters. The support for implicit filters will be done in a seperate PR.
This also fixes some of the problems in the filter functions. Following figure shows the fixed filter kerenels.
🆕 Changelog