-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 9.4.6 #12055
Bump version to 9.4.6 #12055
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,33 @@ endif(${INSTALL_TESTING_FILES} MATCHES ON) | |
install(TARGETS KratosMedCore DESTINATION libs ) | ||
install(TARGETS KratosMedApplication DESTINATION libs ) | ||
|
||
file(TO_CMAKE_PATH "${HDF5_ROOT}/bin" HDF5_ROOT_DEP) | ||
file(TO_CMAKE_PATH "${MED_ROOT}/lib" MED_ROOT_DEP) | ||
|
||
# Track down DLL and install them along with Kratos libs. | ||
# This is disabled until I can make it work in linux. Please do not delete it. | ||
# install(CODE "set(HDF5_ROOT_DEP \"${HDF5_ROOT_DEP}\")") | ||
# install(CODE "set(MED_ROOT_DEP \"${MED_ROOT_DEP}\")") | ||
# install(CODE [[ | ||
# file(GET_RUNTIME_DEPENDENCIES | ||
# RESOLVED_DEPENDENCIES_VAR RES | ||
# UNRESOLVED_DEPENDENCIES_VAR UNRES | ||
# CONFLICTING_DEPENDENCIES_PREFIX CONFLICTING_DEPENDENCIES | ||
# DIRECTORIES ${HDF5_ROOT_DEP} ${MED_ROOT_DEP} | ||
# LIBRARIES $<TARGET_FILE:KratosMedCore> | ||
# PRE_EXCLUDE_REGEXES "api-ms-" "ext-ms-" | ||
# POST_EXCLUDE_REGEXES ".*system32/.*\\.dll" | ||
# ) | ||
|
||
# foreach(_file ${RES}) | ||
# file(INSTALL | ||
# DESTINATION "${CMAKE_INSTALL_PREFIX}/libs" | ||
# TYPE SHARED_LIBRARY | ||
# FILES "${_file}" | ||
# ) | ||
# endforeach() | ||
# ]]) | ||
Comment on lines
+85
to
+107
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this left intentional? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, I put a commenet about that :P. Currently only works on win because its different with so. I will fix it asap but the FullDebug CI has prio and I don't want to remove or leave that aside There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, ofc I only read the first line of the commend 🤦 |
||
|
||
# Define custom targets | ||
set(KRATOS_KERNEL "${KRATOS_KERNEL};KratosMedCore" PARENT_SCOPE) | ||
set(KRATOS_PYTHON_INTERFACE "${KRATOS_PYTHON_INTERFACE};KratosMedApplication" PARENT_SCOPE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legend
I am happy you got asked for win support of the MED-App before I did 🤝 :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣