Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 9.4.6 #12055

Merged
merged 4 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ endif(POLICY CMP0057)
# Set here the version number **** only update upon tagging a release!
set (KratosMultiphysics_MAJOR_VERSION 9)
set (KratosMultiphysics_MINOR_VERSION 4)
set (KratosMultiphysics_PATCH_VERSION 3)
set (KratosMultiphysics_PATCH_VERSION 6)

# If KRATOS_SOURCE_DIR is not defined use the CMAKE_SOURCE_DIR
if(NOT DEFINED KRATOS_SOURCE_DIR)
Expand Down
27 changes: 27 additions & 0 deletions applications/MedApplication/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,33 @@ endif(${INSTALL_TESTING_FILES} MATCHES ON)
install(TARGETS KratosMedCore DESTINATION libs )
install(TARGETS KratosMedApplication DESTINATION libs )

file(TO_CMAKE_PATH "${HDF5_ROOT}/bin" HDF5_ROOT_DEP)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legend

I am happy you got asked for win support of the MED-App before I did 🤝 :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

file(TO_CMAKE_PATH "${MED_ROOT}/lib" MED_ROOT_DEP)

# Track down DLL and install them along with Kratos libs.
# This is disabled until I can make it work in linux. Please do not delete it.
# install(CODE "set(HDF5_ROOT_DEP \"${HDF5_ROOT_DEP}\")")
# install(CODE "set(MED_ROOT_DEP \"${MED_ROOT_DEP}\")")
# install(CODE [[
# file(GET_RUNTIME_DEPENDENCIES
# RESOLVED_DEPENDENCIES_VAR RES
# UNRESOLVED_DEPENDENCIES_VAR UNRES
# CONFLICTING_DEPENDENCIES_PREFIX CONFLICTING_DEPENDENCIES
# DIRECTORIES ${HDF5_ROOT_DEP} ${MED_ROOT_DEP}
# LIBRARIES $<TARGET_FILE:KratosMedCore>
# PRE_EXCLUDE_REGEXES "api-ms-" "ext-ms-"
# POST_EXCLUDE_REGEXES ".*system32/.*\\.dll"
# )

# foreach(_file ${RES})
# file(INSTALL
# DESTINATION "${CMAKE_INSTALL_PREFIX}/libs"
# TYPE SHARED_LIBRARY
# FILES "${_file}"
# )
# endforeach()
# ]])
Comment on lines +85 to +107
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this left intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I put a commenet about that :P.

Currently only works on win because its different with so. I will fix it asap but the FullDebug CI has prio and I don't want to remove or leave that aside

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ofc I only read the first line of the commend 🤦


# Define custom targets
set(KRATOS_KERNEL "${KRATOS_KERNEL};KratosMedCore" PARENT_SCOPE)
set(KRATOS_PYTHON_INTERFACE "${KRATOS_PYTHON_INTERFACE};KratosMedApplication" PARENT_SCOPE)
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ RUN C:\TEMP\vs_buildtools.exe --quiet --wait --norestart --nocache \
$ErrorActionPreference = 'Stop'

#install chocolatey
ENV chocolateyVersion '1.4.0'
RUN powershell.exe -Command \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
iex ((New-Object System.Net.WebClient).DownloadString('http://chocolatey.org/install.ps1'))
Expand Down Expand Up @@ -82,7 +83,7 @@ RUN powershell.exe -Command \
c:\python\311\python.exe -m pip install --upgrade pip; \
c:\python\311\python.exe -m pip install --upgrade setuptools wheel

# Download and extract boost
# Download and extract hdf5
RUN powershell.exe -Command \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
wget https://hdf-wordpress-1.s3.amazonaws.com/wp-content/uploads/manual/HDF5/HDF5_1_12_2/source/hdf5-1.12.2.zip -OutFile c:\TEMP\hdf5.zip; \
Expand All @@ -92,12 +93,25 @@ RUN powershell.exe -Command \
mkdir c:\hdf5\source; \
7z x c:\TEMP\hdf5.zip -o"c:\hdf5\source"

# Download and extract med
RUN powershell.exe -Command \
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; \
wget 'https://www.salome-platform.org/?sdm_process_download=1"&"download_id=2540' -OutFile c:\TEMP\med.tar.bz; \
mkdir c:\med\build; \
mkdir c:\med\bin; \
mkdir c:\med\source; \
7z x c:\TEMP\med.tar.bz -o"c:\TEMP\med.tar"; \
7z x c:\TEMP\med.tar -o"c:\med\source"; \
dir "c:\med\source"

# Build Hdf5 lib
RUN powershell.exe -Command \
cd 'c:/Program Files/CMake/bin/'; \
./cmake.exe -H"c:\hdf5\source\hdf5-1.12.2" -B"c:\hdf5\build" -DCMAKE_INSTALL_PREFIX="c:\hdf5\bin" -DBUILD_TESTING=OFF -DBUILD_SHARED_LIBS=ON; \
./cmake.exe --build "c:\hdf5\build" --target install -- /property:configuration=Release

# Build med lib
Run dir c:\med\source
RUN powershell.exe -Command \
cd 'c:/Program Files/CMake/bin/'; \
./cmake.exe -H"c:\med\source\med-5.0.0" -B"c:\med\build" -DCMAKE_INSTALL_PREFIX="c:\med\bin" -DMEDFILE_BUILD_TESTS=OFF -DMEDFILE_BUILD_SHARED_LIBS=ON -DHDF5_ROOT="c:\hdf5\bin"; \
Expand Down
2 changes: 1 addition & 1 deletion scripts/wheels/build_release_linux.ps1
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$RELEASE_BRANCH="Release-9.4.3"
$RELEASE_BRANCH="Release-9.4.6"

$HOST_SWAP="C:/data_swap_host"
$GUEST_SWAP="/data_swap_guest"
Expand Down
2 changes: 1 addition & 1 deletion scripts/wheels/build_release_windows.ps1
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$RELEASE_BRANCH="Release-9.4.3"
$RELEASE_BRANCH="Release-9.4.6"

$HOST_SWAP="C:/data_swap_host"
$GUEST_SWAP="C:/data_swap_guest"
Expand Down
2 changes: 1 addition & 1 deletion scripts/wheels/linux/build.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash
PYTHONS=("cp38" "cp39" "cp310" "cp311")
export KRATOS_VERSION="9.4.3"
export KRATOS_VERSION="9.4.6"

BASE_LD_LIBRARY_PATH=$LD_LIBRARY_PATH
export KRATOS_ROOT="/workspace/kratos/Kratos"
Expand Down
2 changes: 1 addition & 1 deletion scripts/wheels/windows/build.ps1
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
param([System.String]$cotire="OFF")

$pythons = "38", "39", "310", "311"
$env:kratos_version = "9.4.3"
$env:kratos_version = "9.4.6"

$kratosRoot = "c:\kratos\kratos"
$env:kratos_root = $kratosRoot
Expand Down
Loading