Bump version to 9.4.6 #12055
Merged
Bump version to 9.4.6 #12055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
previously approved these changes
Feb 13, 2024
| @@ -79,6 +79,33 @@ endif(${INSTALL_TESTING_FILES} MATCHES ON) | |||
| install(TARGETS KratosMedCore DESTINATION libs ) | |||
| install(TARGETS KratosMedApplication DESTINATION libs ) | |||
|
|
|||
| file(TO_CMAKE_PATH "${HDF5_ROOT}/bin" HDF5_ROOT_DEP) | |||
There was a problem hiding this comment.
legend
I am happy you got asked for win support of the MED-App before I did 🤝 :D
rubenzorrilla
approved these changes
Mar 7, 2024
philbucher
reviewed
Mar 7, 2024
Comment on lines
+85
to
+107
| # Track down DLL and install them along with Kratos libs. | ||
| # This is disabled until I can make it work in linux. Please do not delete it. | ||
| # install(CODE "set(HDF5_ROOT_DEP \"${HDF5_ROOT_DEP}\")") | ||
| # install(CODE "set(MED_ROOT_DEP \"${MED_ROOT_DEP}\")") | ||
| # install(CODE [[ | ||
| # file(GET_RUNTIME_DEPENDENCIES | ||
| # RESOLVED_DEPENDENCIES_VAR RES | ||
| # UNRESOLVED_DEPENDENCIES_VAR UNRES | ||
| # CONFLICTING_DEPENDENCIES_PREFIX CONFLICTING_DEPENDENCIES | ||
| # DIRECTORIES ${HDF5_ROOT_DEP} ${MED_ROOT_DEP} | ||
| # LIBRARIES $<TARGET_FILE:KratosMedCore> | ||
| # PRE_EXCLUDE_REGEXES "api-ms-" "ext-ms-" | ||
| # POST_EXCLUDE_REGEXES ".*system32/.*\\.dll" | ||
| # ) | ||
|
|
||
| # foreach(_file ${RES}) | ||
| # file(INSTALL | ||
| # DESTINATION "${CMAKE_INSTALL_PREFIX}/libs" | ||
| # TYPE SHARED_LIBRARY | ||
| # FILES "${_file}" | ||
| # ) | ||
| # endforeach() | ||
| # ]]) |
There was a problem hiding this comment.
Yep, I put a commenet about that :P.
Currently only works on win because its different with so. I will fix it asap but the FullDebug CI has prio and I don't want to remove or leave that aside
There was a problem hiding this comment.
Oh, ofc I only read the first line of the commend 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Bumps version to 9.4.6 and fixes issues with the docker image and the med package.
No need to merge for the Release, but would be good to have eventually as 9.4.4 and, 9.4.5 bumps were never merged