[Core] Optimize allocation and MPI management in #11719 #11857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… core/modify-spatial-search-result-container-vector-indexing
|
@pooyan-dadvand this is the modification I mentioned earlier, I don't add it directly to the PR branch of #11719. This PR should be reviewed and if approved, should be done before than #11719 |
|
I think unordered_set can easily outperform any ordered list with binary search. (I remember it from some comparisons I read years ago but I don't have the link now) So I would simply use unordered_set instead. |
… core/modify-spatial-search-result-container-vector-indexing
|
Closing until some refactors are done |
roigcarlo
approved these changes
Dec 20, 2023
kratos/spatial_containers/spatial_search_result_container_vector.cpp
Outdated
Show resolved
Hide resolved
…r-vector-indexing
Co-authored-by: Carlos Roig <roigcarlo@users.noreply.github.com>
Co-authored-by: Carlos Roig <roigcarlo@users.noreply.github.com>
… core/modify-spatial-search-result-container-vector-indexing
Co-authored-by: Carlos Roig <roigcarlo@users.noreply.github.com>
…r-vector-indexing
… core/modify-spatial-search-result-container-vector-indexing
…r-vector-indexing
… core/modify-spatial-search-result-container-vector-indexing
… core/modify-spatial-search-result-container-vector-indexing
…for Barrier method and the index retrieval
… core/modify-spatial-search-result-container-vector-indexing
|
I will merge this and the following changes will be done in an independent branch and merged to the main one as this pR intended |
loumalouomega
merged commit cde548f
into
core/mpi/spatial-search-container-new-proposal-v3
16 of 17 checks passed
loumalouomega
deleted the
core/modify-spatial-search-result-container-vector-indexing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR tries to optimize the allocation and improve #11719. We maybe require to add asyncronous interface to the data communicator in order to properly fix the missing changes.
🆕 Changelog
GetSubDataCommunicatortoDataCommunicatorandMPIDataCommunicator#11875