Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing hash again.. #85

Open
anas-p13 opened this issue Aug 30, 2020 · 6 comments
Open

missing hash again.. #85

anas-p13 opened this issue Aug 30, 2020 · 6 comments

Comments

@anas-p13
Copy link

well now they just randomly repositioned the image, resulting in missing hashes error (i guess so)
example:
new
cherubi new
old
cherubi old
note that not all the images are repositioned like this, they all were moved to random directions
thank you

@anas-p13
Copy link
Author

anas-p13 commented Sep 3, 2020

some images are also cut out by the frame
like this
unknown

also it seems like they gonna do this regularly

@wulavi
Copy link

wulavi commented Sep 4, 2020

If you're too busy to help us, could you at least teach/tell us how to hash our own images? The only way I know how is by seeing it spawn and having the main,py program say the hash but it's much harder that way.

@Kr4ken-9
Copy link
Owner

Kr4ken-9 commented Sep 8, 2020

If you are interested in hashing your own images, you can look into https://github.com/JohannesBuchner/imagehash

imagehash is the library that DAB uses to compute perceptual hashes for images. It is well documented.
You can also look at this file for how hashes were computed en masse: https://github.com/Kr4ken-9/DAB/blob/master/pokebad/hashing.py

Someone with knowledge of DAB could extend it or rewrite it to save images and their hashes when a pokemon spawns so that you could later look at it and tell DAB the name of the pokemon. However, this was not how it was originally designed, and I do not have time to do it myself. I will also probably not be investing any more of my time in this project.

Otherwise, someone with knowledge could create a crowdsourced pokebois.json (or hash database) so that multiple people could contribute hashes. This seems like the most sustainable path forward.

@anas-p13
Copy link
Author

anas-p13 commented Sep 8, 2020

oh its kinda sad to know about this, but i understand
so thank you! you have been a great help

Someone with knowledge of DAB could extend it or rewrite it to save images and their hashes when a pokemon spawns so that you could later look at it and tell DAB the name of the pokemon. However, this was not how it was originally designed, and I do not have time to do it myself. I will also probably not be investing any more of my time in this project.

also about this, it would be great if dab shows the image too along with missing hash so we can fix it

@JociNik
Copy link

JociNik commented Sep 9, 2020

they made an anti-bot system which adds a grain filter, changes the background tone a bit and repositions the pokémon for each spawn (sometimes moving it out of frame), so the hash is always different and the DAB bot will not be able to recognize it, here is the best example i found:
First spawn

Second spawn (26 minutes later, same channel)

Pokédex entry (original pic, how spawns were before they added the anti-bot system)

@anas-p13
Copy link
Author

anas-p13 commented Sep 10, 2020

oh, so there is not point in updating the hash then?, as they keep on changing every half an hour
is there any way to overcome this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants