Stabilize FastDoubleParser part 1 #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all other locales, not just ROOT. Finished parse tests
Jolanrensen
force-pushed
the
stabilize-fast-double-parser
branch
from
ad272d8 to
89e0d41
Compare
Jolanrensen
added
documentation
zaleslaw
approved these changes
Feb 12, 2025
docs/StardustDocs/topics/parse.md
Outdated
| You can also set global parser options that will be used by default in [`read`](read.md), [`convert`](convert.md), | ||
| and `parse` operations: | ||
| and other `parse` operations. | ||
| These can be seen as a global fallback for the `parserOptions` argument. |
There was a problem hiding this comment.
I suppose we need to be simpler with "fallback" definition and give a short explanation what is this, how it influences on something or add some references who are not familiar with that
There was a problem hiding this comment.
alright, expanded a bit on it
| fun `converting String to Double in different locales`() { | ||
| val currentLocale = Locale.getDefault() | ||
| val systemLocale = Locale.getDefault() |
There was a problem hiding this comment.
is it machine dependent test?
There was a problem hiding this comment.
no, this backs up the system locale and restores it at the end of the test. During the test we set Locale.setDefault() to be machine independant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1039
useFastDoubleParserparser option to true by default.FastDoubleParserfallback mechanism to use all possible safe alternative decimal symbols for a given locale.parsedocumentation on the website with the behavior of the fallback mechanism etc.