Skip to content

Consider changing convert { }.to { } operation #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koperagen opened this issue Apr 25, 2025 · 1 comment · Fixed by #1134
Closed

Consider changing convert { }.to { } operation #1150

koperagen opened this issue Apr 25, 2025 · 1 comment · Fixed by #1134
Assignees

Comments

@koperagen
Copy link
Collaborator

koperagen commented Apr 25, 2025

df.convert { }.asColumn { } restricts name change
df.convert { }.to { } is the same as df.replace { }.with { } - and even recommended as such in the documentation
We could either restrict name change in df.convert { }.to { }, keep it as is, or remove df.convert { }.to { }
related to #1143

@koperagen koperagen self-assigned this Apr 25, 2025
@koperagen koperagen added this to the 1.0.0-Beta1 (0.16) milestone Apr 25, 2025
@Jolanrensen
Copy link
Collaborator

I vote for removing df.convert { }.to { } because it's confusingly named the same as df.convert { }.to<Int>(). It's not clear from the name when to choose to/with whereas asColumn/with is easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants