Skip to content

Candidates for removal #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koperagen opened this issue Jan 24, 2025 · 1 comment
Open

Candidates for removal #1028

koperagen opened this issue Jan 24, 2025 · 1 comment

Comments

@koperagen
Copy link
Collaborator

koperagen commented Jan 24, 2025

We aim to stabilize API, but before that we need to remove a number of functions that do not bring clear value, don't seem useful. That includes shortcuts - things that can be easily replaced with other functions, or poorly designed API that can be re-introduced later, or things that don't have a use case

Here we'll keep a list of functions that can we consider for removal and want to hear from you. Please share your opinion if something should be kept as is

DataRow.isEmpty and DataRow.isNotEmpty - hard to imagine situation where it'd be used
DataFrame.copy is useless
DataRow.getRows() is a short cut that can be easily replaced with df().get(), and also hard to imagine a usecase

These two IMO should be renamed to addAll to give priority for add("col") { } which is a primary way to add columns
public fun <T> DataFrame<T>.add(vararg columns: AnyBaseCol): DataFrame<T> = addAll(columns.asIterable())
public fun <T> DataFrame<T>.add(vararg dataFrames: AnyFrame): DataFrame<T> = addAll(dataFrames.asIterable())

@koperagen
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants