feat: option to recycle timer context #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
force-pushed
the
refactor
branch
7 times, most recently
from
182f04c to
0dfc4c7
Compare
Keeping the timer context alive can cause memory leaks. Hence a new option to set the number of invocations to use a context before recreating the timer in a new context.
Tieske
force-pushed
the
refactor
branch
5 times, most recently
from
7710e68 to
0b0d797
Compare
|
@locao since we figured this one out: https://github.com/Kong/lua-resty-timer/pull/11/files#diff-62bd0b4b2f58444dda4d468eb58071b931b443ddb4be4d9797c3cd2f61ca059bR34-R38 (credits to Javier), I think this is now good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a timer context is implemented as a request under the hood. This means that it is supposed to be short-lived. As such some calls leak memory within a context, which is not a problem when the context is short-lived and freed as a whole. But if we hold on to timer contexts indefinitely, it becomes a real memory leak. Hence the new option to recycle the timer context after
max_usenumber of invocations (by default 1000).It is implemented in such a way that if the creation of the replacement timer fails (due to lack of timer resources), it will continue in the existing context. This makes the timer resilient to lack-of-timer-resource type errors.