fix(ktabs): allow tab anchors to be links [KHCP-13866] #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portikM
requested review from
adamdehaven,
jillztom,
Justineo and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
previously requested changes
Dec 2, 2024
johncowen
reviewed
Dec 2, 2024
johncowen
reviewed
Dec 2, 2024
adamdehaven
reviewed
Dec 2, 2024
adamdehaven
reviewed
Dec 2, 2024
adamdehaven
reviewed
Dec 3, 2024
docs/components/tabs.md
Outdated
Comment on lines
271
to
273
| ## Usage | ||
|
|
||
| ### Tab links |
There was a problem hiding this comment.
I'm not sure I understand the new "Usage" section here -- can we just document "Tabs as Links" under the Props instead (above the Slots section)
There was a problem hiding this comment.
Done. Made it a subheading under tabs prop since it mostly relates to that prop
There was a problem hiding this comment.
adamdehaven
approved these changes
Dec 3, 2024
kongponents-bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
## [9.14.18](v9.14.17...v9.14.18) (2024-12-03) ### Bug Fixes * **ktabs:** allow tab anchors to be links [KHCP-13866] ([#2532](#2532)) ([cdf5caa](cdf5caa))
|
🎉 This PR is included in version 9.14.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
johncowen
added a commit
to kumahq/kuma-gui
that referenced
this pull request
Jan 30, 2025
Several people have reported issue with being able to click on our tab component i.e. you have to click exactly on the text instead of being able to click on the entire button. A recent kongponent update (Kong/kongponents#2532) changed the padding of certain HTML elements, which removed the padding from our anchor links and added it to the surrounding div instead, meaning whilst it looked like you could click on the entire button to click the anchor, you where actually clicking the div, meaning the anchor wasn't navigating. Also see https://github.com/Kong/kongponents/pull/2532/files#diff-01f83cc2092a263bfd47c1d0a4ba5e96dea98264d85282662a63f4fa18c44dedR177 This PR rearranges the padding using some overwrites to return the anchor its previous padded state. There is still a little unclickable area between the button and the bottom border, but I think this is intentional form the kongponents authors. The additional difference with this area is that at least you don't see a pointer cursor when hovering over it. Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13866
Add
toproperty inTabinterface to support rendering tabs as links