tests(*): make nginx_worker_processes to take effect properly #14222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nginx_worker_processes` is the standard configuration in our template, and it has an alias `nginx_main_worker_processes`. So, no matter which one we configure, both will work. However, if we set these options at the same time, the one that takes effect will be `nginx_main_worker_processes`. Since our test suite uses [`nginx_main_worker_processes`](https://github.com/Kong/kong/blob/7a505eaa6870a5 b9e7da914a32464635691f1038/spec/kong_tests.conf#L35), that means using `nginx_worker_processes` in the test cases is not working. We have a bunch of test files that are using `nginx_worker_processes` instead of the `nginx_main_worker_processes` alias, and making one small change to the kong_test.conf file saves us the trouble of updating all of them (including EE).
github-actions
bot
added
the
cherry-pick kong-ee
bungle
approved these changes
Jan 28, 2025
ProBrian
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nginx_worker_processesis the standard configuration in our template, and it has an aliasnginx_main_worker_processes. So, no matter which one we configure, both will work. However, if we set these options at the same time, the one that takes effect will benginx_main_worker_processes.Since our test suite uses
nginx_main_worker_processes, that means usingnginx_worker_processesin the test cases is not working.We have a bunch of test files that are using
nginx_worker_processesinstead of thenginx_main_worker_processesalias, and making one small change to the kong_test.conf file saves us the trouble of updating all of them (including EE).Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]