Skip to content

Commit

Permalink
fix(llm): mark model.options.upstream_path as deprecated (#14178)
Browse files Browse the repository at this point in the history
model.options.upstream_path caused some confusion in some drivers (namely openai and huggingface) a static prefix is always attached while others are not.

it’s also causing conflicts with upstream_url

Users would be able to move to use upstream_url to archieve same functionality.

AG-201
  • Loading branch information
fffonion authored Feb 6, 2025
1 parent 2582e76 commit 0ba6c08
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/deprecate-llm-upstream-url.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: '**AI Plugins**: Deprecated config.model.options.upstream_path in favor of config.model.options.upstream_url.'
type: deprecation
scope: Plugin
5 changes: 4 additions & 1 deletion kong/llm/schemas/init.lua
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,10 @@ local model_options_schema = {
description = "Manually specify or override the AI operation path, "
.. "used when e.g. using the 'preserve' route_type.",
type = "string",
required = false }},
required = false,
deprecation = {
message = "llm: config.model.options.upstream_path is deprecated, please use config.model.options.upstream_url instead",
removal_in_version = "4.0",}, }},
{ gemini = gemini_options_schema },
{ bedrock = bedrock_options_schema },
{ huggingface = huggingface_options_schema},
Expand Down

1 comment on commit 0ba6c08

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel Build

Docker image available kong/kong-dev:0ba6c08739f26f15d78a66b9f9b846fda1433e23
Artifacts available https://github.com/Kong/kong/actions/runs/13176788887

Please sign in to comment.