Skip to content

refactor(sdk): only display error message without stacktrace for minor errors #8606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

refactor(sdk): only display error message without stacktrace for minor errors #8606

merged 3 commits into from
Apr 24, 2025

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 14, 2025 •
edited
Loading

Change

  • Throw a string message instead an error -- Originally I introduced a custom error to do this, but after discussed within team, we plan to avoid introducing error abstraction too early.
  • Reformat outputs into message and stack.

Without stack:
image

With stack:
image

@ihexxa ihexxa self-assigned this Apr 14, 2025
@ihexxa ihexxa marked this pull request as draft April 14, 2025 08:31
@ihexxa ihexxa force-pushed the refactor/sdk/error branch 2 times, most recently from 24e66d6 to 5beb5bc Compare April 23, 2025 09:15
@ihexxa ihexxa force-pushed the refactor/sdk/error branch from 5beb5bc to 5424cf3 Compare April 24, 2025 02:36
@ihexxa ihexxa marked this pull request as ready for review April 24, 2025 06:19
@jackkav jackkav merged commit 7b5cddb into develop Apr 24, 2025
10 checks passed
@jackkav jackkav deleted the refactor/sdk/error branch April 24, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihexxa @jackkav