feat(konnect): add KonnectDataPlaneGroupConfiguration reconciler #1186
+1,248
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
konnect-add-dataplanegroupconfiguration-reconciler
branch
7 times, most recently
from
8595fb9 to
4dc5f3c
Compare
controller/konnect/ops/ops_konnectdataplanegroupconfigurations.go
Outdated
Show resolved
Hide resolved
controller/konnect/ops/ops_konnectdataplanegroupconfigurations.go
Outdated
Show resolved
Hide resolved
test/envtest/konnect_entities_konnectdataplanegroupconfiguration_test.go
Outdated
Show resolved
Hide resolved
test/envtest/konnect_entities_konnectdataplanegroupconfiguration_test.go
Outdated
Show resolved
Hide resolved
pmalek
commented
Feb 21, 2025
test/envtest/konnect_entities_konnectdataplanegroupconfiguration_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
pmalek
force-pushed
the
konnect-add-dataplanegroupconfiguration-reconciler
branch
from
adb4c1b to
615a938
Compare
programmer04
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for
KonnectDataPlaneGroupConfigurationCRD (added in Kong/kubernetes-configuration#307)Some notes:
KonnectCloudGatewayDataPlaneGroupConfigurationcan be applied to be effective, as using more than 1 against a single Control Plane will result in configurations overriding each otherWhich issue this PR fixes
Fixes #1114
Special notes for your reviewer:
Required changes from Kong/kubernetes-configuration#307
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes