Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: use KIC as a library in ControlPlane controller #1177

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
+526 −2,384
Draft

[WIP] feat: use KIC as a library in ControlPlane controller #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14cb078
feat: use KIC as a library in ControlPlane controller
czeslavo Feb 18, 2025
18bb7fd
pass conformance
czeslavo Feb 21, 2025
43dec4c
lint
czeslavo Feb 21, 2025
d2d247b
skip failing e2e, add telepresence to integration
czeslavo Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ download.shellcheck: mise yq ## Download shellcheck locally if necessary.
@$(MISE) plugin install --yes -q shellcheck
@$(MISE) install -q shellcheck@$(SHELLCHECK_VERSION)

.PHONY: download.telepresence
download.telepresence: ## Download telepresence locally if necessary.
./hack/install-telepresence.sh

.PHONY: use-setup-envtest
use-setup-envtest:
$(SETUP_ENVTEST) use
Expand Down Expand Up @@ -399,7 +403,8 @@ test.crds-validation.pretty:
$(MAKE) _test.envtest GOTESTSUM_FORMAT=testname ENVTEST_TEST_PATHS=./test/crdsvalidation/...

.PHONY: _test.integration
_test.integration: gotestsum
_test.integration: gotestsum download.telepresence
PATH=$(PROJECT_DIR)/bin:$(PATH) \
GOFLAGS=$(GOFLAGS) \
GOTESTSUM_FORMAT=$(GOTESTSUM_FORMAT) \
$(GOTESTSUM) -- $(GOTESTFLAGS) \
Expand Down Expand Up @@ -440,7 +445,8 @@ NCPU := $(shell getconf _NPROCESSORS_ONLN)
PARALLEL := $(if $(PARALLEL),$(PARALLEL),$(NCPU))

.PHONY: _test.conformance
_test.conformance: gotestsum
_test.conformance: gotestsum download.telepresence
PATH=$(PROJECT_DIR)/bin:$(PATH) \
GOTESTSUM_FORMAT=$(GOTESTSUM_FORMAT) \
$(GOTESTSUM) -- $(GOTESTFLAGS) \
-timeout $(CONFORMANCE_TEST_TIMEOUT) \
Expand Down
26 changes: 0 additions & 26 deletions config/rbac/role/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ rules:
- ""
resources:
- configmaps
- serviceaccounts
- services
verbs:
- create
Expand Down Expand Up @@ -58,18 +57,6 @@ rules:
- get
- patch
- update
- apiGroups:
- admissionregistration.k8s.io
resources:
- validatingwebhookconfigurations
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apiextensions.k8s.io
resources:
Expand Down Expand Up @@ -443,16 +430,3 @@ rules:
- patch
- update
- watch
- apiGroups:
- rbac.authorization.k8s.io
resources:
- clusterrolebindings
- clusterroles
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
Loading
Loading