fix(konnect): fix handling conflicts

CHANGELOG.md

@@ -158,6 +158,8 @@
   [#1115](https://github.com/Kong/gateway-operator/pull/1115)
 - Fix setting `DataPlane`'s readiness probe using `GatewayConfiguration`.
   [#1118](https://github.com/Kong/gateway-operator/pull/1118)
+- Fix handling Konnect API conflicts.
+  [#1176](https://github.com/Kong/gateway-operator/pull/1176)
 
 ## [v1.4.2]
 

controller/konnect/ops/ops_errors.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"net/http"
 	"slices"
+	"strings"
 
 	sdkkonnecterrs "github.com/Kong/sdk-konnect-go/models/sdkerrors"
 	"github.com/go-logr/logr"
@@ -94,7 +95,6 @@ func ParseSDKErrorBody(body string) (sdkErrorBody, error) {
 }
 
 const (
-	dataConstraintMesasge   = "data constraint error"
 	validationErrorMessage  = "validation error"
 	apiErrorOccurredMessage = "API error occurred"
 )
@@ -202,14 +202,20 @@ func SDKErrorIsConflict(sdkError *sdkkonnecterrs.SDKError) bool {
 		return false
 	}
 
-	if sdkErrorBody.Message != dataConstraintMesasge {
-		return false
-	}
+	const (
+		dataConstraintMesasge      = "data constraint error"
+		typeUniqueConstraintFailed = "(type: unique) constraint failed"
+	)
 
-	switch sdkErrorBody.Code {
-	case 3, 6:
-		return true
+	if sdkErrorBody.Message == dataConstraintMesasge ||
+		strings.Contains(sdkErrorBody.Message, typeUniqueConstraintFailed) {
+
+		switch sdkErrorBody.Code {
+		case 3, 6:
+			return true
+		}
 	}
+
 	return false
 }
 

controller/konnect/ops/ops_errors_test.go

@@ -140,3 +140,81 @@ func TestErrorIsCreateConflict(t *testing.T) {
 		})
 	}
 }
+
+func TestSDKErrorIsConflict(t *testing.T) {
+	tests := []struct {
+		name string
+		err  *sdkkonnecterrs.SDKError
+		want bool
+	}{
+		{
+			name: "SDKError with data constraint error message and code 3",
+			err: &sdkkonnecterrs.SDKError{
+				Body: `{
+					"code": 3,
+					"message": "data constraint error",
+					"details": []
+				}`,
+			},
+			want: true,
+		},
+		{
+			name: "SDKError with data constraint error message and code 6",
+			err: &sdkkonnecterrs.SDKError{
+				Body: `{
+					"code": 6,
+					"message": "data constraint error",
+					"details": []
+				}`,
+			},
+			want: true,
+		},
+		{
+			name: "SDKError with unique constraint failed message",
+			err: &sdkkonnecterrs.SDKError{
+				Body: `{
+					"code": 3,
+					"message": "name (type: unique) constraint failed",
+					"details": []
+				}`,
+			},
+			want: true,
+		},
+		{
+			name: "SDKError with non-conflict message",
+			err: &sdkkonnecterrs.SDKError{
+				Body: `{
+					"code": 3,
+					"message": "some other error",
+					"details": []
+				}`,
+			},
+			want: false,
+		},
+		{
+			name: "SDKError with conflict message but different code",
+			err: &sdkkonnecterrs.SDKError{
+				Body: `{
+					"code": 4,
+					"message": "data constraint error",
+					"details": []
+				}`,
+			},
+			want: false,
+		},
+		{
+			name: "SDKError with invalid JSON body",
+			err: &sdkkonnecterrs.SDKError{
+				Body: `invalid json`,
+			},
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := SDKErrorIsConflict(tt.err)
+			require.Equal(t, tt.want, got)
+		})
+	}
+}