Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extension to display message indicating lack of macOS support and developer support on Linux #92

Closed
jcfr opened this issue Apr 26, 2022 · 0 comments · Fixed by #93
Closed

Update extension to display message indicating lack of macOS support and developer support on Linux #92

jcfr opened this issue Apr 26, 2022 · 0 comments · Fixed by #93
Assignees
@lassoan

Comments

@jcfr
Copy link
Contributor

jcfr commented Apr 26, 2022 •
edited
Loading

Since OpenVR is only available and functional on Windows, a scripted module with a name similar to the loadable one could be conditionally built and installed.

Per platform status

image
https://slicer.cdash.org/index.php?project=SlicerPreview&date=2022-04-26&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=Virtual

Associated issues:
@jcfr jcfr changed the title Update extension to display message indicating lack of macOS and Linux support Update extension to display message indicating lack of macOS supportm and developer support on Linux Apr 26, 2022
lassoan added a commit to lassoan/SlicerVirtualReality that referenced this issue Apr 26, 2022
@lassoan
Fix extension build on macOS by replacing real Virtual Reality module…
41ba4de 
… by a placeholder

Virtual Reality is not supported on macOS. Instead of having a build error on the dashboard
and extension missing from the Extensions Manager, we now create an extension that contains
a stub module that just displays the message that Virtual Reality is not supported on the platform.

fixes KitwareMedical#92
@lassoan lassoan mentioned this issue Apr 26, 2022
Merged
lassoan added a commit that referenced this issue Apr 27, 2022
@lassoan @jcfr
Fix extension build on macOS by replacing real Virtual Reality module…
70d5a3b 
… by a placeholder

Virtual Reality is not supported on macOS. Instead of having a build error on the dashboard
and extension missing from the Extensions Manager, we now create an extension that contains
a stub module that just displays the message that Virtual Reality is not supported on the platform.

fixes #92

Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
@lassoan lassoan changed the title Update extension to display message indicating lack of macOS supportm and developer support on Linux Update extension to display message indicating lack of macOS support and developer support on Linux Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jcfr @lassoan