Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS support #3

Open
jcfr opened this issue Oct 17, 2017 · 4 comments · Fixed by #150, #149 or #164
Open

Add MacOS support #3

jcfr opened this issue Oct 17, 2017 · 4 comments · Fixed by #150, #149 or #164
Assignees

Comments

@jcfr
Copy link
Contributor

jcfr commented Oct 17, 2017

If anybody would use MacOS for virtual reality and you already have virtual reality capable hardware then post a comment here. Also describe how can you contribute to the effort.

@lassoan lassoan changed the title macOS: Fix packaging of OpenVR framework Add MacOS support Dec 17, 2018
@lassoan
Copy link
Collaborator

lassoan commented Dec 17, 2018

TODO: Fix packaging of OpenVR framework

Since OpenVR.framework is a directory, it should be installed as such.

https://github.com/KitwareMedical/SlicerOpenVR/blob/17c78d31edd43fc686c2f38fed4a0212323c79ec/SuperBuild/External_OpenVR.cmake#L52-L54

The following code should be improved:

https://github.com/KitwareMedical/SlicerOpenVR/blob/17c78d31edd43fc686c2f38fed4a0212323c79ec/CMakeLists.txt#L48-L53

@jcfr
Copy link
Contributor Author

jcfr commented Jan 12, 2024

Support for building the extension was made possible through the following pull requests:

While the extension build, it doesn't provide any integration with XR environment. Enabling OpenXR leads to the following failure when building vtkRenderingOpenXR:

Issue related to "XrGraphicsBindingOpenGL"

Here is the error reported while building the vtkRenderingOpenXR module:

    [ 15%] Building CXX object vtkRenderingOpenXR/CMakeFiles/RenderingOpenXR.dir/vtkOpenXRManagerConnection.cxx.o
  In file included from /D/S/A/VTK/Rendering/OpenXR/vtkOpenXRManagerOpenGLGraphics.cxx:15:
  /D/S/A/VTK/Rendering/OpenXR/vtkOpenXRManagerOpenGLGraphics.h:119:19: error: use of undeclared identifier 'XrGraphicsBindingOpenGL'
    std::shared_ptr<XrGraphicsBindingOpenGL> GraphicsBinding;
                    ^
  /D/S/A/VTK/Rendering/OpenXR/vtkOpenXRManagerOpenGLGraphics.h:49:16: error: cannot initialize return object of type 'vtkObjectBase *' with an rvalue of type 'vtkOpenXRManagerOpenGLGraphics *'
    vtkTypeMacro(vtkOpenXRManagerOpenGLGraphics, vtkOpenXRManagerGraphics);
    ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@jcfr
Copy link
Contributor Author

jcfr commented Feb 29, 2024

Closing. We should revisit the macOS support once VTK itself support it.

@jcfr jcfr closed this as completed Feb 29, 2024
@lassoan
Copy link
Collaborator

lassoan commented Feb 29, 2024

We need to keep this issue open so that people who are waiting for macOS support can keep monitoring this issue.
Maybe we could add labels etc. to distinguish this feature request from issues.

@jcfr jcfr reopened this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment