Add ImageResliceMapper multi component using multiple image data #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions used a `getInput` method that doesn't exist It is not a breaking change as these functions instantly crash when called
The ImageSlice actor already used a more concise code. Do the same for the base Actor and and Volume actor.
The prop3D has three children that were redefining `getBounds` in the same way. Move the definition of `getBounds` in the prop3D. Update typescript accordingly.
BREAKING CHANGE: Move vtkVolumeMapper's properties related to rendering in vtkVolumeProperty. Add a clear error message for these widely used methods. This is part of the MultiVolumeMapper feature.
This work is part of the MultiVolumeMapper feature Fix the getVolumes function which didn't return an array
Instead of comparing a big state that take all actor properties into account, compare the mtime of the actor as it takes properties into account
bruyeret
force-pushed
the
image-reslice-multi-component
branch
4 times, most recently
from
132be4b
to
d625f71
Compare
finetjul
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
light seems to be coming from top, then it is strange that the side of the bottom part is very lit.
There was a problem hiding this comment.
The changes here come from the other PR, maybe I should change the target to bruyeret:multi-component instead of Kitware:master
It is hard to know if lighting is wrong with a still image, but this is strange indeed
Support multiple images as input Uniform styling of fragment shader Fix resource sharing core object for volume mapper scalars Many shader bugs are fixed, often linked to wrong coordinate system. Fix normal computation in shader. BREAKING CHANGE: the volume mapper fragment shader is very different. This can cause shader replacements to break. refactor: Use the right matrices in volume FS shader
The normals have been fixed in the shader, hence the difference Also the sample distance is not computed in index space anymore This explains some differences
BREAKING CHANGE: getTransferFunctionHash becomes getTransferFunctionsHash It takes a list of functions as argument instead of a single function Also ImageResliceMapper doesn't wieght color using mix.
bruyeret
force-pushed
the
image-reslice-multi-component
branch
from
d625f71
to
111f193
Compare
|
I made this PR so that anyone can see the diff between this PR and the #3132 PR |
bruyeret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #3132. It adds the same kind of support for multi image, but for the vtkImageResliceMapper.
The vtkImageResliceMapper now supports up to 4 inputs, each representing a component.
The first volume property will be used for all rendering properties except interpolationType.
There is a breaking change so it should be merged at the same time as #3132