-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch roi info #724
Fetch roi info #724
Conversation
…lected by the cropping planes
aa347a2
to
317799b
Compare
317799b
to
d74a2ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bueno!
src/createViewer.js
Outdated
if (typeof name === 'undefined') { | ||
name = context.images.selectedName | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (typeof name === 'undefined') { | |
name = context.images.selectedName | |
} | |
const imageName = name ?? context.images.selectedName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most excellent 👩🎤 !
Typo noted inline
src/ImJoyPluginAPI.js
Outdated
@@ -358,6 +358,18 @@ class ImJoyPluginAPI { | |||
getCompareImages(name) { | |||
return this.viewer.getCompareImages(name) | |||
} | |||
|
|||
getloadedScale(scale) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getLoadedScale
, l
-> L
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my 🙃 Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎇
🎉 This PR is included in version 14.44.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Provide the API that we need in order to retrieve information about the data bounds for the current region of interest, as defined by the cropping planes.