Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch roi info #724

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Fetch roi info #724

merged 4 commits into from
Dec 6, 2023

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Dec 6, 2023

Provide the API that we need in order to retrieve information about the data bounds for the current region of interest, as defined by the cropping planes.

Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bueno!

Comment on lines 1261 to 1263
if (typeof name === 'undefined') {
name = context.images.selectedName
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (typeof name === 'undefined') {
name = context.images.selectedName
}
const imageName = name ?? context.images.selectedName

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent 👩‍🎤 !

Typo noted inline

@@ -358,6 +358,18 @@ class ImJoyPluginAPI {
getCompareImages(name) {
return this.viewer.getCompareImages(name)
}

getloadedScale(scale) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLoadedScale, l -> L

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and calls

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my 🙃 Fixed!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇

@thewtex thewtex merged commit bfb2144 into Kitware:master Dec 6, 2023
6 checks passed
@bnmajor bnmajor deleted the fetch-roi-info branch December 6, 2023 18:23
Copy link

github-actions bot commented Dec 6, 2023

🎉 This PR is included in version 14.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants