feat(createLayerInterface): add download button #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
commented
Dec 1, 2023
Comment on lines
+14
to
+19
| type: 'SAVE_ROI', | ||
| data: { | ||
| name: event.data.name, | ||
| layerName: event.data.layerName, | ||
| croppingPlanes, | ||
| }, |
There was a problem hiding this comment.
Thee emited event payload.
PaulHax
commented
Dec 1, 2023
| @@ -183,6 +183,9 @@ const createViewer = async ( | |||
| break | |||
| case 'TAKE_SCREENSHOT': | |||
| break | |||
| case 'SAVE_ROI': | |||
| eventEmitter.emit('saveRoi', event.data) | |||
This was referenced Dec 2, 2023
thewtex
requested changes
Dec 4, 2023
There was a problem hiding this comment.
The workflow for itkwidgets / python side is:
- create a viewer
- select an roi
- there are getters to get the current roi on the viewer
- the client code calls the getter and their logic to save the image to file
The download button should bring up a modal to select format and file name parameters and a download button that saves the file locally.
We should not be emitting an event / payload for the save ROI.
The download button is not used for this because of a) how event processing occurs in jupyter and b) how the roi is obtained and save logic is implemented in Python.
-> please add the download modal and remove the event
|
Closing in favor of #727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.