New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new skinning issues #558

Open

1 of 4 tasks

lexaknyazev opened this issue Jan 22, 2020 · 1 comment

Member

lexaknyazev commented Jan 22, 2020 •

edited

Loading

After updating the validator there are a few new skinning issues in the generated models (see reports for details):

Animation_Skin_02
- NODE_SKINNED_MESH_NON_ROOT
- NODE_SKINNED_MESH_LOCAL_TRANSFORMS
Animation_Skin_06
- SKIN_NO_COMMON_ROOT
Animation_Skin_07 and Animation_Skin_10 (see Fix unused joint indices #559)
- ACCESSOR_JOINTS_USED_ZERO_WEIGHT

The text was updated successfully, but these errors were encountered:

Member Author

lexaknyazev commented Jan 25, 2020

The description of Animation_Skin_02 says:

skinA where the skinned node has a transform and a parent node with a transform. Both transforms should be ignored.

So it seems that the warnings should remain intact, i.e. we won't fix them.

The description of Animation_Skin_06 says:

skinA where joint1 is a root node and not a child of joint0.

This is clearly a violation of the "common root" requirement, so this model should either be fixed or removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment