Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VK_GOOGLE_surfaceless_query #1636

Conversation

charles-lunarg
Copy link
Collaborator

Requires bypassing the logic which dereferences VkSurfaceKHR in
vkGetPhysicalDeviceSurfaceFormatsKHR and
vkGetPhysicalDeviceSurfacePresentModesKHR. This should have been done
closer to the release of VK_GOOGLE_surfaceless_query, but because that
extension was meant for Android, which isn't supported by this loader,
it was not done. That said, SwiftShader can support the extension, so
support is now being added in this commit.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346295.

@charles-lunarg charles-lunarg linked an issue Jan 15, 2025 that may be closed by this pull request
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346312.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2855 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2855 failed.

@charles-lunarg charles-lunarg force-pushed the support_google_surfaceless_query branch from d8f3e89 to 360a77b Compare January 15, 2025 22:00
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346347.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346364.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2857 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2857 failed.

@charles-lunarg charles-lunarg force-pushed the support_google_surfaceless_query branch from 360a77b to 757324b Compare January 15, 2025 22:20
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346402.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346419.

@charles-lunarg charles-lunarg force-pushed the support_google_surfaceless_query branch from 757324b to 580c657 Compare January 15, 2025 22:23
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346420.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2860 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346456.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2861 running.

@charles-lunarg charles-lunarg force-pushed the support_google_surfaceless_query branch from 580c657 to d9f10cf Compare January 15, 2025 22:32
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346475.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2862 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 346493.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2863 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2863 failed.

@charles-lunarg charles-lunarg force-pushed the support_google_surfaceless_query branch from d9f10cf to 6f80ef8 Compare January 16, 2025 16:49
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 347479.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2864 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 347497.

Requires bypassing the logic which dereferences VkSurfaceKHR in
vkGetPhysicalDeviceSurfaceFormatsKHR and
vkGetPhysicalDeviceSurfacePresentModesKHR. This should have been done
closer to the release of VK_GOOGLE_surfaceless_query, but because that
extension was meant for Android, which isn't supported by this loader,
it was not done. That said, SwiftShader can support the extension, so
support is now being added in this commit.
@charles-lunarg charles-lunarg force-pushed the support_google_surfaceless_query branch from 6f80ef8 to c758b06 Compare January 16, 2025 17:02
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build queued with queue ID 347502.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2866 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 2866 passed.

@charles-lunarg charles-lunarg merged commit 35a851d into KhronosGroup:main Jan 16, 2025
44 checks passed
@charles-lunarg charles-lunarg deleted the support_google_surfaceless_query branch January 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please support VK_GOOGLE_surfaceless_query
2 participants