Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip building hello_xr test #454

Closed
wants to merge 1 commit into from
Closed

Option to skip building hello_xr test #454

wants to merge 1 commit into from

Conversation

lvonasek
Copy link

@lvonasek lvonasek commented Feb 7, 2024

hello_xr test doesn't compile on Android out of the box. It requires defining "OS_LINUX" and including glad library.

Having hello_xr as a mandragory dependency complicates using this repository as a submodule and it is blocking for integrating OpenXR in Dolphin emulator.

@lvonasek
Copy link
Author

lvonasek commented Feb 7, 2024

I do not understand what is wrong with the "Generate archive" flow. Could anyone help?

@rpavlik
Copy link
Contributor

rpavlik commented Feb 7, 2024

The workflows here are messed up, I haven't had a chance to fix them. I assume it's probably not because of your change.

Is there a reason why you're not just using the artifacts from Maven Central that we publish and recommend?

(Also, you should just be able to disable tests for this as a submodule, and/or, use the OpenXR-SDK repo which is intended for submodule usage, and only contains the loader.)

Also it definitely should build for Android out of the box, though CMake won't make a full APK, the CMake is run by Gradle to build the native code. What is your build environment that you're having issues? (And where does it mention glad? I was pretty sure that change was reverted entirely before the last release due to an issue on Android and so shouldn't have been public.)

@lvonasek
Copy link
Author

lvonasek commented Feb 8, 2024

Is there a reason why you're not just using the artifacts from Maven Central that we publish and recommend?

There is a requirement to support both Android standalone and PCVR on Windows.

(Also, you should just be able to disable tests for this as a submodule, and/or, use the OpenXR-SDK repo which is intended for submodule usage, and only contains the loader.)

I had to dig into the CitraVR integration which I use as a reference. OpenXR loader doesn't work on Meta Quest OS V62. They are using this workaround: https://github.com/amwatson/OpenXR-SDK-Source/commits/main/
(feel free to create an issue for this one)


However, thank you for pointing me on OpenXR-SDK repo. I will use it once it is compatible with the current Quest OS.

@lvonasek lvonasek closed this Feb 8, 2024
@lvonasek lvonasek deleted the hello_xr_option branch February 8, 2024 08:11
@rpavlik
Copy link
Contributor

rpavlik commented Feb 8, 2024

yeah a fix equivalent to that will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants