Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure culture information respects browser locale #3

Merged

Conversation

liamgold
Copy link
Contributor

@liamgold liamgold commented Feb 9, 2024

Motivation

Currently dates are being displayed using the culture en-US, but could be displayed in the appropriate format based on the browser locale. Adding the RequestLocalizationMiddleware corrects this.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

Copy link
Member

@seangwright seangwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking with it!

@seangwright seangwright merged commit 5c25055 into Kentico:main Feb 14, 2024
1 check passed
@liamgold liamgold deleted the fix/add-request-localization-middleware branch February 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants