Skip to content

Commit ffd93aa

Browse files
committed
deps!: bump ethermint to fix EIP712 message signing
Previous version of ethermint used a value for the `verifyingContract` in the domain separator that was not compliant with the spec. This field and `salt`, which was unused, have been removed. This is a state breaking change because it changes which EIP712 txs are considered valid, and therefore, which txs are allowed to be included in a block.
1 parent 6ec2513 commit ffd93aa

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ Ref: https://keepachangelog.com/en/1.0.0/
3636

3737
## [unreleased]
3838

39+
### State Machine Breaking Changes
40+
41+
- (ethermint) [ethermint#75] Remove unused fields `verifyingContract` & `salt` from EIP712 domain separator.
42+
- Resolves inability to sign EIP712 messages with Metamask.
43+
3944
### Features
4045

4146
- (cli) [#2017] Support CLI `completion` for bash, zsh, fish, & powershell.
@@ -402,6 +407,7 @@ the [changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.38.4/CHANGELOG.md).
402407

403408
[ethermint#82]: https://github.com/Kava-Labs/ethermint/pull/82
404409
[ethermint#77]: https://github.com/Kava-Labs/ethermint/pull/77
410+
[ethermint#75]: https://github.com/Kava-Labs/ethermint/pull/75
405411
[#2017]: https://github.com/Kava-Labs/kava/pull/2017
406412
[#1988]: https://github.com/Kava-Labs/kava/pull/1988
407413
[#1973]: https://github.com/Kava-Labs/kava/pull/1973

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ replace (
236236
// See https://github.com/cosmos/cosmos-sdk/pull/13093
237237
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
238238
// Use ethermint fork that respects min-gas-price with NoBaseFee true and london enabled, and includes eip712 support
239-
github.com/evmos/ethermint => github.com/kava-labs/ethermint v0.21.0-kava-v26.6
239+
github.com/evmos/ethermint => github.com/kava-labs/ethermint v0.21.0-kava-v27.0
240240
// See https://github.com/cosmos/cosmos-sdk/pull/10401, https://github.com/cosmos/cosmos-sdk/commit/0592ba6158cd0bf49d894be1cef4faeec59e8320
241241
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0
242242
// Downgraded to avoid bugs in following commits which causes "version does not exist" errors

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -891,8 +891,8 @@ github.com/kava-labs/cometbft-db v0.9.1-kava.2 h1:ZQaio886ifvml9XtJB4IYHhlArgA3+
891891
github.com/kava-labs/cometbft-db v0.9.1-kava.2/go.mod h1:PvUZbx7zeR7I4CAvtKBoii/5ia5gXskKjDjIVpt7gDw=
892892
github.com/kava-labs/cosmos-sdk v0.47.10-iavl-v1-kava.2 h1:rbUXwJFlrRd05G1D5S5zAlmTTBbkcf0w36QFf5+i9tk=
893893
github.com/kava-labs/cosmos-sdk v0.47.10-iavl-v1-kava.2/go.mod h1:OwLYEBcsnijCLE8gYkwQ7jycZZ/Acd+a83pJU+V+MKw=
894-
github.com/kava-labs/ethermint v0.21.0-kava-v26.6 h1:9MUnu1xe7Oc3kv0CtvRtBMbPBUcpKZnQsbVJhWA8L0M=
895-
github.com/kava-labs/ethermint v0.21.0-kava-v26.6/go.mod h1:zGcUyJhdcoO0VfxAQwiXpGjBAV8w+Hig1yaH2l7KB5k=
894+
github.com/kava-labs/ethermint v0.21.0-kava-v27.0 h1:TzFhLQULsyQUA+b620FMGvZHTNriRuWLFGShwW/4xCA=
895+
github.com/kava-labs/ethermint v0.21.0-kava-v27.0/go.mod h1:zGcUyJhdcoO0VfxAQwiXpGjBAV8w+Hig1yaH2l7KB5k=
896896
github.com/kava-labs/iavl v1.2.0-kava.2 h1:RfEqQ9u7fvhzXOfYxxqEnVNCTb3pYJiT7X86N6cgI0M=
897897
github.com/kava-labs/iavl v1.2.0-kava.2/go.mod h1:nNoeUFw64lfPvcj3yZ7W7BvmlTxu9ANGsJcUiPSOAdw=
898898
github.com/kisielk/errcheck v1.1.0/go.mod h1:EZBBE59ingxPouuu3KfxchcWSUPOHkagtvWXihfKN4Q=

0 commit comments

Comments
 (0)