Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37709 - make sure content_source_id is not changed during host edit #11097

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sbernhard
Copy link
Member

@sbernhard sbernhard commented Aug 2, 2024

What are the changes introduced in this pull request?

The content_source_id is not transmitted if you edit a host and therefore the value of the host group is used.

Considerations taken when implementing this change?

Similar to Lifecycle / Content View implementation.

What are the testing steps for this pull request?

Works with new host and edit host.

@sbernhard sbernhard changed the title Fixes #37709 - make sure content_source_id is not changed during host… Fixes #37709 - make sure content_source_id is not changed during host edit Aug 2, 2024
@jeremylenz jeremylenz requested a review from qcjames53 August 2, 2024 14:31
@dosas
Copy link
Contributor

dosas commented Aug 5, 2024

Is it possible to test this within katello?

@sbernhard
Copy link
Member Author

Is it possible to test this within katello?

Don't think so. Maybe something for robottelo.

Copy link
Contributor

@qcjames53 qcjames53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bernhard! I was able to verify that a host with a custom content source maintains its value when updating other host properties on the edit host form. Selecting a content source during creation, using this same form, seems to work just as before.

With a different host PR we ended up adding Katello documentation after the fact to specify what host fields are inherited from the host group; this is useful for users using hammer, API, etc where the fields need to be manually populated. I'll check with Brian Angelica if content_source was one of those fields, and if not we'll update the docs.

Everything looks great to me. ACKing :)

@qcjames53 qcjames53 merged commit c98aede into Katello:master Aug 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants