Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37162 - Make sure ESXi check in is reflected in sub facet #10887

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

chris1984
Copy link
Member

@chris1984 chris1984 commented Feb 13, 2024

What are the changes introduced in this pull request?

  • When the hypervisors checkin from a virt-who report we call the method update_hosts which calls update_subscripiton_facet
  • In update_subscripiton_facet we were not declaring the checkin time. We only created a fake subscription_facet for an ESXi host on initial check-in and creation
  • Since ESXi does not have rhsmcertd running, it cannot check in like a RHEL host can and update its own subscription_facet
  • This makes sure each time we get a report from virt-who we make sure the checkin time in the UI reflects when the report was recieved

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  • Either install virt-who configure plugin either by adding it to forklift in extra plugins, or cloning the repo, adding to bundler.d in the foreman directory and then doing a db:migrate db:seed or spin up a stream box with Beaker
  • Check out PR
  • Create a config for VMware (Ping me for creds) set it for an hour or lower
  • Run the deploy scripts for each one, verify that each report updates in the UI
  • Check the UI to make sure the check in time reflects correctly
  • Check on it for a few hours with virt-who running on your box and see if you notice it keeping up with the check in

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that host.subscription_facet.last_checkin gets updated when the hypervisor checks in.

Tested via waiting and via restarting virt-who to trigger an upload.

@chris1984 chris1984 merged commit 72394b6 into Katello:master Feb 27, 2024
12 of 15 checks passed
@chris1984 chris1984 deleted the fix-hypervisor branch February 27, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants