Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37118 - Remove Virtual Guests in legacy UI for non hypervisors #10870

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • Virtual guests is returning an empty array when the host does not have any virtual guests. This is not present in the new UI, and I don't want to disrupt anything in the consumer.rb which could break something. Since the old UI will be going away soon and the issue is only present there, I just changed that section to hide that field/value if the array is empty.
  • This does work correctly when virt-who reports in because then we do have values in the virtual_guest array, I did check this on my box and confirms the field shows up correctly.

Considerations taken when implementing this change?

  • See above

What are the testing steps for this pull request?

  • Register your devel box or a client to your Katello devel box
  • Check out the old UI and see that is has a section called Virtual Guests (0)
  • Check out PR
  • Verify that section is gone

Screenshot before:
guestbefore

Screenshot after:
guestafter

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with my webpack5 setup, works well

thanks @chris1984 ! ACK 👍

@chris1984 chris1984 merged commit 136a73e into Katello:master Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants