Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37117 - Add link to SCA warning banner #10868

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

jeremylenz
Copy link
Member

What are the changes introduced in this pull request?

Add a hyperlink to the SCA warning banner on the Organization Edit page.

image

Considerations taken when implementing this change?

This PR will be irrelevant once Katello 4.12 is branched, so it can't go on the master branch. Therefore, I am raising it against the KATELLO-4.11 branch.

The original suggestion was to change the wording from

Simple Content Access will be required for all organizations in Katello 4.12.

to

Simple Content Access is mandatory from Katello 4.12.

but I think "mandatory" sounds too harsh and punishing. So I left it as-is.

What are the testing steps for this pull request?

verify that the link works and opens in a new tab

@jeremylenz jeremylenz changed the base branch from KATELLO-4.11 to master January 30, 2024 17:44
@jeremylenz jeremylenz changed the base branch from master to KATELLO-4.11 January 30, 2024 17:44
@chris1984 chris1984 self-assigned this Feb 2, 2024
@jeremylenz
Copy link
Member Author

React failures unrelated.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prsca

ACK, works great!

@jeremylenz jeremylenz merged commit b4b898a into Katello:KATELLO-4.11 Feb 5, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants